refactor(semantic): move the semantic packages into internal/semantic - #441
Merged
Merged
Conversation
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Moves symbols, suggest, resolve, semantics, identity, highlight and query from internal/core to internal/semantic and rewrites their imports. query declares the three namespace IRIs it needs instead of importing rdf, so the package sits in the semantic layer. Co-Authored-By: jason.han <hanhuijun@gmail.com>
…ential baseline The self-model's Go package references moved to internal/semantic. Co-Authored-By: jason.han <hanhuijun@gmail.com>
devin-ai-integration
Bot
force-pushed
the
refactor/layer-syntax
branch
from
September 19, 2026 15:30
03ee364 to
e780885
Compare
devin-ai-integration
Bot
force-pushed
the
refactor/layer-semantic
branch
from
September 19, 2026 15:30
fcd8fa0 to
1b2d503
Compare
Co-Authored-By: jason.han <hanhuijun@gmail.com>
Co-Authored-By: jason.han <hanhuijun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Second step of the layer-directory move, on top of the
internal/syntaxpull request. Moves the semantic packages intointernal/semantic/:highlight(classifies source text using the resolver) andquery(the transport-neutral element-query model thatqueryexec,grpcandreplconsume) join this layer.One edit is not a pure move:
query/oslc.goimportedinternal/core/rdffor therdf:,xsd:andsysml:namespace IRIs of the OSLC prefix map, which would have made a semantic-layer package depend on the translation layer.querynow declares those three IRIs as unexported constants (rdfNS,xsdNS,sysmlNS, same literals asrdf/vocab.go, which is unchanged), and the layering test pinssemantic/query → rdfas a removed edge.Everything else is the mechanical import rewrite across the root module and
tools/, path strings in tests, the self-model'sgoPackagereferences and the citations indocs/project/validation-constraints.md; theexamplesdigest indocs/project/pilot-differential-baseline.jsonis re-recorded for that reason only.How it was verified
go build ./...,go vet ./...,gofmt -l .(empty),make lint,make docs-check, the full suite withOPENSYSML_REQUIRE_TRAINING_CORPUS=1 OPENSYSML_REQUIRE_PILOT_CORPORA=1 OPENSYSML_REQUIRE_PILOT_LIBRARY_XMI=1 go test -count=1 ./...(79 packages ok), thetools/module (build, vet, test,doc-counts -check),python3 scripts/changelog.py check.go list ./internal/... | wc -l(59) and thefunc Testcount (9006) matchdevelop.Checklist
make testandmake lintpass locallychanges/unreleased/<slug>.<section>.md, not as an edit toCHANGELOG.mdmake docs-countsrun if a gate count moved (compliance rows need nothing: the census is counted at docs build)F4,K5) in the body, docs, or changelog