refactor(ir): move the semantic IR packages into internal/ir - #442
Merged
Merged
Conversation
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
Moves lower, queryplan, docplan and view from internal/core to internal/ir and rewrites their imports. Co-Authored-By: jason.han <hanhuijun@gmail.com>
… baseline The self-model's Go package references moved to internal/ir. Co-Authored-By: jason.han <hanhuijun@gmail.com>
devin-ai-integration
Bot
force-pushed
the
refactor/layer-semantic
branch
from
September 19, 2026 15:30
fcd8fa0 to
1b2d503
Compare
devin-ai-integration
Bot
force-pushed
the
refactor/layer-ir
branch
from
September 19, 2026 15:30
2320b2e to
9c783b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Third step of the layer-directory move, on top of the
internal/semanticpull request. Moves the semantic-IR packages intointernal/ir/:viewjoins this layer: it consumeslowerand is consumed bydocplan, so the IR layer is the only one it fits.A mechanical relocation:
git mv, import-path rewrite across the root module andtools/, the layering-test keys,sonar-project.properties, the self-model'sgoPackagereferences and one relative fixture path indocplan's tests (thedocrenderfixture it reads has not moved yet). Theexamplesdigest indocs/project/pilot-differential-baseline.jsonis re-recorded because the self-model'sgoPackagestrings changed; no other figure moved.How it was verified
go build ./...,go vet ./...,gofmt -l .(empty),make lint,make docs-check, the full suite withOPENSYSML_REQUIRE_TRAINING_CORPUS=1 OPENSYSML_REQUIRE_PILOT_CORPORA=1 OPENSYSML_REQUIRE_PILOT_LIBRARY_XMI=1 go test -count=1 ./...(79 packages ok), thetools/module (build, vet, test,doc-counts -check),python3 scripts/changelog.py check.go list ./internal/... | wc -l(59) is unchanged;TestPackageLayeringreports no edge fromirintocheckorexec.Checklist
make testandmake lintpass locallychanges/unreleased/<slug>.<section>.md, not as an edit toCHANGELOG.mdmake docs-countsrun if a gate count moved (compliance rows need nothing: the census is counted at docs build)F4,K5) in the body, docs, or changelog