refactor(exec): move the execution packages into internal/exec - #444
Merged
Merged
Conversation
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Moves runtime, solve, smt, analysis (with enginewire and modelform), engines and objref from internal/core to internal/exec and rewrites their imports. Co-Authored-By: jason.han <hanhuijun@gmail.com>
…al baseline The self-model's Go package references moved to internal/exec. Co-Authored-By: jason.han <hanhuijun@gmail.com>
Co-Authored-By: jason.han <hanhuijun@gmail.com>
Co-Authored-By: jason.han <hanhuijun@gmail.com>
devin-ai-integration
Bot
force-pushed
the
refactor/layer-check
branch
from
September 19, 2026 15:30
fe3087f to
47ac419
Compare
devin-ai-integration
Bot
force-pushed
the
refactor/layer-exec
branch
from
September 19, 2026 15:30
05903de to
4d1f4c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Fifth step of the layer-directory move, on top of the
internal/checkpull request. Moves the execution packages intointernal/exec/:A mechanical relocation:
git mv, import-path rewrite across the root module andtools/, the layering-test keys and pins (analysis → export,enginewire → export,export → runtime,runtime → parser, passeskeep their new paths;execis still not permitted to importcheck), the relative fixture paths thatcmd/sysml,repl,grpc,formatandmodeltests read fromruntime's andanalysis's testdata,scripts/pgo-profile.sh,sonar-project.propertiesand the self-model'sgoPackagereferences.Two gates forced small edits outside the code: the analysis-library census compares its recorded
commandstring verbatim, sodocs/project/analysis-library-census.jsonnow names./internal/exec/runtime(no measurement changed;make docs-countsre-rendered the one line indocs/project/spec-compliance.md), and the link checker required the threeinternal/core/runtime/testdata/...links indocs/guide/06-behavior.mdto follow the move. Theexamplesdigest indocs/project/pilot-differential-baseline.jsonis re-recorded because the self-model'sgoPackagestrings changed; no other figure moved.How it was verified
go build ./...,go vet ./...,gofmt -l .(empty),make lint,make docs-check, the full suite withOPENSYSML_REQUIRE_TRAINING_CORPUS=1 OPENSYSML_REQUIRE_PILOT_CORPORA=1 OPENSYSML_REQUIRE_PILOT_LIBRARY_XMI=1 go test -count=1 ./..., thetools/module (build, vet, test,doc-counts -check),python3 scripts/changelog.py check.go list ./internal/... | wc -l(59) is unchanged;TestPackageLayeringreports no edge fromexecintocheck.Checklist
make testandmake lintpass locallychanges/unreleased/<slug>.<section>.md, not as an edit toCHANGELOG.mdmake docs-countsrun if a gate count moved (compliance rows need nothing: the census is counted at docs build)F4,K5) in the body, docs, or changelog