refactor(workspace): move the workspace packages into internal/workspace - #447
Merged
Merged
Conversation
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Moves model, libs (with errata), project and envvar from internal/core to internal/workspace and rewrites their imports. Co-Authored-By: jason.han <hanhuijun@gmail.com>
… pilot baselines The self-model's Go package references moved to internal/workspace and the library errata paths moved to internal/workspace/libs/stdlib. Co-Authored-By: jason.han <hanhuijun@gmail.com>
…t-xpect baseline Co-Authored-By: jason.han <hanhuijun@gmail.com>
devin-ai-integration
Bot
force-pushed
the
refactor/layer-doc
branch
from
September 19, 2026 15:30
990382e to
bcfd218
Compare
devin-ai-integration
Bot
force-pushed
the
refactor/layer-workspace
branch
from
September 19, 2026 15:30
37171fb to
2419b16
Compare
Contributor
Author
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Eighth step of the layer-directory move, on top of the
internal/docpull request. Moves the workspace packages intointernal/workspace/:A mechanical relocation:
git mv, import-path rewrite across the root module andtools/(tools/gen/snapshot,tools/census/grammar), the layering-test keys and tolerated rows,Makefile'sLIBS_DIR,scripts/pgo-profile.sh, the path comments in the corpus download scripts, the self-model'sgoPackagereferences, and link-only path fixes inREADME.mdanddocs/internals/architecture.mdthat the link checker required.internal/workspace/libs/testdata/training_examples_expected.txtmoves unchanged.Two baseline lines move for path reasons:
examplesdigest indocs/project/pilot-differential-baseline.json, because the self-model'sgoPackagestrings changed;provenance.errataRegistrydigest (and the errata entries'pathstrings) indocs/project/pilot-differential-baseline.json,docs/project/pilot-rejection-baseline.jsonanddocs/project/pilot-xpect-baseline.json, because it hashes the errata entries' paths, which embedlibs/errata'sLibraryRootconstant — nowinternal/workspace/libs/stdlib. Re-recorded withpilot-diff -update,pilot-reject -updateandpilot-xpect -update; the bucket counts are identical to the committed ones (pilot-xpect: 1296 agree / 30 disagree).How it was verified
go build ./...,go vet ./...,gofmt -l .(empty),make lint,make docs-check, the full suite withOPENSYSML_REQUIRE_TRAINING_CORPUS=1 OPENSYSML_REQUIRE_PILOT_CORPORA=1 OPENSYSML_REQUIRE_PILOT_LIBRARY_XMI=1 go test -count=1 ./...(79 packages ok, none failing), thetools/module (build, vet, test;doc-counts -check),python3 scripts/changelog.py check.go list ./internal/... | wc -l(59) is unchanged.Checklist
make testandmake lintpass locallychanges/unreleased/<slug>.<section>.md, not as an edit toCHANGELOG.mdmake docs-countsrun if a gate count moved (compliance rows need nothing: the census is counted at docs build)F4,K5) in the body, docs, or changelog