Skip to content

refactor(workspace): move the workspace packages into internal/workspace - #447

Merged
HuiJun merged 3 commits into
developfrom
refactor/layer-workspace
Sep 19, 2026
Merged

HuiJun merged 3 commits into
developfrom
refactor/layer-workspace

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

What and why

Eighth step of the layer-directory move, on top of the internal/doc pull request. Moves the workspace packages into internal/workspace/:

internal/core/{model,libs (with errata),project,envvar} → internal/workspace/{model,libs,project,envvar}

A mechanical relocation: git mv, import-path rewrite across the root module and tools/ (tools/gen/snapshot, tools/census/grammar), the layering-test keys and tolerated rows, Makefile's LIBS_DIR, scripts/pgo-profile.sh, the path comments in the corpus download scripts, the self-model's goPackage references, and link-only path fixes in README.md and docs/internals/architecture.md that the link checker required. internal/workspace/libs/testdata/training_examples_expected.txt moves unchanged.

Two baseline lines move for path reasons:

  • the examples digest in docs/project/pilot-differential-baseline.json, because the self-model's goPackage strings changed;
  • the provenance.errataRegistry digest (and the errata entries' path strings) in docs/project/pilot-differential-baseline.json, docs/project/pilot-rejection-baseline.json and docs/project/pilot-xpect-baseline.json, because it hashes the errata entries' paths, which embed libs/errata's LibraryRoot constant — now internal/workspace/libs/stdlib. Re-recorded with pilot-diff -update, pilot-reject -update and pilot-xpect -update; the bucket counts are identical to the committed ones (pilot-xpect: 1296 agree / 30 disagree).

How it was verified

go build ./..., go vet ./..., gofmt -l . (empty), make lint, make docs-check, the full suite with OPENSYSML_REQUIRE_TRAINING_CORPUS=1 OPENSYSML_REQUIRE_PILOT_CORPORA=1 OPENSYSML_REQUIRE_PILOT_LIBRARY_XMI=1 go test -count=1 ./... (79 packages ok, none failing), the tools/ module (build, vet, test; doc-counts -check), python3 scripts/changelog.py check. go list ./internal/... | wc -l (59) is unchanged.

Checklist

  • make test and make lint pass locally
  • Tests added or updated for the change
  • Documentation extended where it already covers the surface (see CONTRIBUTING.md)
  • Changelog entry added as changes/unreleased/<slug>.<section>.md, not as an edit to CHANGELOG.md
  • baselines regenerated and make docs-counts run if a gate count moved (compliance rows need nothing: the census is counted at docs build)
  • No internal work-item labels (waves, slices, F4, K5) in the body, docs, or changelog

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

devin-ai-integration Bot and others added 3 commits September 19, 2026 15:15
Moves model, libs (with errata), project and envvar from internal/core to
internal/workspace and rewrites their imports.

Co-Authored-By: jason.han <hanhuijun@gmail.com>
… pilot baselines

The self-model's Go package references moved to internal/workspace and
the library errata paths moved to internal/workspace/libs/stdlib.

Co-Authored-By: jason.han <hanhuijun@gmail.com>
…t-xpect baseline

Co-Authored-By: jason.han <hanhuijun@gmail.com>
@devin-ai-integration
devin-ai-integration Bot force-pushed the refactor/layer-workspace branch from 37171fb to 2419b16 Compare September 19, 2026 15:30
@devin-ai-integration
devin-ai-integration Bot marked this pull request as ready for review September 19, 2026 17:28

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Devin Review: 1 flag

Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)

Devin Review

Base automatically changed from refactor/layer-doc to develop September 19, 2026 18:02
@HuiJun
HuiJun merged commit 103526d into develop Sep 19, 2026
12 checks passed
@HuiJun
HuiJun deleted the refactor/layer-workspace branch September 19, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant