Skip to content

Replace Devlooped.CredentialManager with Microsoft.AspNetCore.DataProtection.Extensions - #20

Merged
datah4zard merged 3 commits into
Open-Source-Free-Realms:mainfrom
datah4zard:security
Jul 12, 2026
Merged

datah4zard merged 3 commits into
Open-Source-Free-Realms:mainfrom
datah4zard:security

Conversation

@datah4zard

@datah4zard datah4zard commented Jul 11, 2026 •

Copy link
Copy Markdown
Contributor

Devlooped.CredentialManager misled me: it has a hard dependency on Git, so it doesn't work for end-users.
This PR switches to the cross-platform Microsoft.AspNetCore.DataProtection.Extensions package and encrypts a JSON password store at rest in the user's app data folder.
Same CredentialHelper interface, so no other code changes needed; migration from pre-v1.1.1 will still work

@datah4zard
datah4zard requested a review from StimpyDev July 11, 2026 22:57
@datah4zard

Copy link
Copy Markdown
Contributor Author

@StimpyDev can you test on Windows without Git please :)

@StimpyDev

Copy link
Copy Markdown
Contributor

If u add the try/catch block, then i'm fine with these changes, u could also use a atomic save instead, altough the chance of corrupting the file mid-save is very low for a launcher.

@datah4zard

Copy link
Copy Markdown
Contributor Author

I don't think we need the overhead of an atomic write; plus, the OS will only let one write handle to a file exist at a time typically, so there shouldn't be any corruption potential from the launcher alone.

@StimpyDev

Copy link
Copy Markdown
Contributor

LGTM

@datah4zard
datah4zard merged commit 8a9954c into Open-Source-Free-Realms:main Jul 12, 2026
1 check passed
@datah4zard

Copy link
Copy Markdown
Contributor Author

@StimpyDev should we do another release to fix this or are you working on any other launcher stuff?

@StimpyDev

Copy link
Copy Markdown
Contributor

@StimpyDev should we do another release to fix this or are you working on any other launcher stuff?

I'm not working on anything rn, going on holiday for 1 week. Only thing i'm currently working on is to get admins/mods get pink names, thats it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants