Repository navigation
Replace Devlooped.CredentialManager with Microsoft.AspNetCore.DataProtection.Extensions - #20
Conversation
…tection.Extensions
|
@StimpyDev can you test on Windows without Git please :) |
|
If u add the try/catch block, then i'm fine with these changes, u could also use a atomic save instead, altough the chance of corrupting the file mid-save is very low for a launcher. |
|
I don't think we need the overhead of an atomic write; plus, the OS will only let one write handle to a file exist at a time typically, so there shouldn't be any corruption potential from the launcher alone. |
|
LGTM |
|
@StimpyDev should we do another release to fix this or are you working on any other launcher stuff? |
I'm not working on anything rn, going on holiday for 1 week. Only thing i'm currently working on is to get admins/mods get pink names, thats it |
Devlooped.CredentialManager misled me: it has a hard dependency on Git, so it doesn't work for end-users.
This PR switches to the cross-platform Microsoft.AspNetCore.DataProtection.Extensions package and encrypts a JSON password store at rest in the user's app data folder.
Same CredentialHelper interface, so no other code changes needed; migration from pre-v1.1.1 will still work