Repository navigation
Give NPCs, guilds, houses and fixtures their own GUID layouts - #164
Merged
GroaxyVRC merged 4 commits intoOct 28, 2026
Merged
Conversation
GroaxyVRC
force-pushed
the
feature/guid-layout
branch
from
October 27, 2026 06:58
6545c34 to
79270ff
Compare
ImAlko
reviewed
Oct 28, 2026
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| private static ulong GetPrefixedGuid(GuidPrefix prefix, ulong id) | ||
| { | ||
| ArgumentOutOfRangeException.ThrowIfGreaterThan(id, MaxPrefixedId); |
Contributor
There was a problem hiding this comment.
You'll have to double check this, but make sure we have handling for anything we're throwing. I don't think we want anything throwing ever on a deployed server.
Just mentioning this in case there's an edge case that causes this (or any other new exceptions) to throw.
ImAlko
approved these changes
Oct 28, 2026
ImAlko
left a comment
ImAlko
left a comment
Contributor
There was a problem hiding this comment.
Approving pending the double check on exception handling
Contributor
Author
|
exception handling stuff will need to be another PR to clean up the repo and check for others. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should work close to how the original game did, FabledRealms.lua still has "hardcoded" guids they make more sense keeping it this way since the original game randomized them each server start, so everytime the server restarts they keep the same GUID no matter what. Housing, Fixtures, Scripted NPCs like wolves spawning should all use a randomized GUID based on the +1 system we already have. We can probably dumb this down a bit more so suggestions are always wanted.