Skip to content

Handle client Lua metrics - #165

Merged
GroaxyVRC merged 1 commit into
Open-Source-Free-Realms:mainfrom
Sulphural:take-me-there
Oct 27, 2026
Merged

GroaxyVRC merged 1 commit into
Open-Source-Free-Realms:mainfrom
Sulphural:take-me-there

Conversation

@Sulphural

Copy link
Copy Markdown
Contributor

Follow-up to #162. Take Me There already works on main, so this only handles the packet that was mistaken for it.

Take Me There is client-side. The tracker button calls the client's TakeMeToObjective, which pathfinds on the client's own navmesh to the objective target (from ObjectiveTargetUpdatePacket) and walks the player there. Any path requests go through ClientPathRequestPacket, which main already answers. Tested in game: the player walks to the objective.

Opcode 142 is PacketClientLuaMetrics, not a Take Me There request. The button also bumps a Lua metric counter, and the client flushes those every 30 seconds as short 142, int count, { uint hash, string name, int value }. Our logs only ever show the TakeMeThere counter (hash 0xBC804F67). It was arriving as an unhandled world packet every 30 seconds.

This adds PacketClientLuaMetrics and a handler that logs each metric at trace level, routed in PacketTunneledClientWorldPacketHandler.

@GroaxyVRC
GroaxyVRC merged commit c08ae88 into Open-Source-Free-Realms:main Oct 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants