Repository navigation
Handle client Lua metrics - #165
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #162. Take Me There already works on main, so this only handles the packet that was mistaken for it.
Take Me There is client-side. The tracker button calls the client's
TakeMeToObjective, which pathfinds on the client's own navmesh to the objective target (fromObjectiveTargetUpdatePacket) and walks the player there. Any path requests go throughClientPathRequestPacket, which main already answers. Tested in game: the player walks to the objective.Opcode 142 is
PacketClientLuaMetrics, not a Take Me There request. The button also bumps a Lua metric counter, and the client flushes those every 30 seconds asshort 142, int count, { uint hash, string name, int value }. Our logs only ever show theTakeMeTherecounter (hash0xBC804F67). It was arriving as an unhandled world packet every 30 seconds.This adds
PacketClientLuaMetricsand a handler that logs each metric at trace level, routed inPacketTunneledClientWorldPacketHandler.