Repository navigation
fix: call the real Agmarknet with its token login again - #100
Open
KrutikaPhirangi wants to merge 3 commits into
Open
KrutikaPhirangi wants to merge 3 commits into
KrutikaPhirangi wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Mandi prices call the real Agmarknet again.
agmarknetgoes back toauthScheme: tokenQueryin both the single-adapter and multi-adapter provider configs, replacing theauthScheme: nonethe in-cluster benchmark mock needed.__AGMARKNET_TOKEN_URL__from the provider Secret'sagmarknetTokenUrl, like the Vistaar token URL. It is a deployment fact, so it is not in the chart.AGMARKNET_ACCESS_NAMEandAGMARKNET_PASSWORDin the provider tier's environment (provider-upstream).adapter-serviceis bumped to 0.8.0, with a changelog entry.Why
Dev should answer mandi prices from the real upstream, not the benchmark's static nginx. With
authScheme: none, the adapter sends no token and the real API rejects every call.Breaking
A release must supply the substitution (
adapterKeys.extraSubstitutionsin single mode,keys.existingSecret.extraSubstitutionsin multi), or the init container stops on the unfilled placeholder:The registry's
agmarknetupstream must also point at the real API, notmock-upstream.Testing
helm lintpasses with all three CI values files. The single-adapter render showstokenQueryand the init container substitutes__AGMARKNET_TOKEN_URL__from/keys/provider/agmarknetTokenUrl. Not run on a cluster.