feat(registry,registry-seed): admit and seed the catalog crawler's publish action by kelvinprabhu · Pull Request #96 · OpenAgriNet/helmcharts

kelvinprabhu · 2026-10-27T10:17:52Z

Refs #77 · Refs OpenAgriNet/network-adapter#54 · Split from #92

Objective

Let the registry hold, and registry-seed write, the publish action that names the pipeline the network adapter's catalog crawler runs for a binding. Split out of #92 so it can be deployed before the crawler.

Solution

registry: publish joins the Action enum, and MappingPath also accepts a <...>/publish/<source>.yaml pipeline URL. Every action still requires method, path and mappings.
registry-seed: bindings[].publishPipelineUrl (optional) appends a publish action (POST /publish) beside select; on a binding that already exists the Job adds or repoints that action with a PUT of the whole record.

Nothing reads the action until the crawler runs (#92), so this is safe to deploy on its own.

Verification

MappingPath checked against the agmarknet SHA-pinned pipeline URL and existing *.select.yaml / *.discover.yml mappings (match), and .., a bare x.yaml, x.publish.yaml (refused).
registry-seed: helm lint passes; a binding with publishPipelineUrl renders and seed.py compiles; the publish helpers tested against a mocked registry (add, already present, repoint, missing row).
charts/registry lint fails on development too (templates/deployment.yaml line 82, unrelated).

Quick-start counterpart: #93 (same schema copy).

Not done

Not run on a cluster.

…blish action registry 0.5.0: ProviderSchema accepts a `publish` action whose mapping is an https <...>/publish/<source>.yaml pipeline URL; select/init/confirm still need method, path and a mapping folder. registry-seed 0.2.0: bindings[].publishPipelineUrl adds that action, pinned to a commit SHA unless allowUnpinnedPipeline is set; on an existing binding the Job adds or repoints it. Nothing reads the action until the network adapter's catalog crawler runs, so this can be deployed ahead of it. Refs #77

The registry's ProviderSchema already refuses a publish mapping that is not an https <...>/publish/<source>.yaml, and the Job then fails naming the binding, so the render-time copy of that regex (and allowUnpinnedPipeline) only duplicated it. Pinning to a commit SHA stays a documented convention in values.yaml. The README row repeated the values comment. Refs #77

kelvinprabhu

Fix Needed

kelvinprabhu · 2026-10-27T10:26:02Z

      "description": "How to call this provider for one Beckn action: where, how, and with which mapping. Anything the upstream needs that the Beckn body cannot express is the adapter plugin's work, not a field here. status is per action, so one can be retired without touching the others. Permits additional properties because the registry re-validates the MERGED document on a PUT, and that document carries the osid, osUpdatedAt and osOwner the registry injected itself -- which a strict schema rejects as extraneous. Do not set this back to false without removing the update requests from the Postman collection.",
      "type": "object",
      "additionalProperties": true,
-      "required": ["action", "method", "path", "mappings", "status"],


why remove existing - > "method", "path",

kelvinprabhu · 2026-10-27T10:26:29Z

        "method":   { "type": "string", "enum": ["GET", "POST"] },
        "path":     { "$ref": "#/definitions/Path" },
-        "mappings": { "$ref": "#/definitions/MappingPath" },
+        "mappings": { "type": "string" },


why changed from the existing code

kelvinprabhu · 2026-10-27T10:29:47Z

+  #
+  #   OPTIONAL -- the pipeline the network adapter's catalog crawler runs for this
+  #   binding, on its own schedule, to build and publish its catalogs. Adds a
+  #   `publish` action to the row (no method or path; the provider adapter's
+  #   routing sends a publish on). Needs registry chart >= 0.5.0, whose
+  #   ProviderSchema admits `publish`.
+  #   publishPipelineUrl: https://raw.githubusercontent.com/OpenAgriNet/network-adapter/<40-hex-sha>/pkg/plugin/implementation/MandiPrice/publish/agmarknet.yaml
+  #
+  #   It must be https, shaped <...>/publish/<source>.yaml with its mappings/
+  #   folder beside it (the registry refuses anything else). Pin it to a commit
+  #   SHA: the crawler fetches the file on every run, so a branch URL changes what
+  #   the adapters execute on every push. On a binding that already exists the
+  #   Job adds or repoints the action in place.


dont add this comments here

kelvinprabhu · 2026-10-27T10:30:36Z

  with.
 type: application
-version: 0.1.1
+version: 0.2.0


keep 0.1.2 only

kelvinprabhu · 2026-10-27T10:31:01Z

+## [0.2.0] - 2026-10-26
+
+### Added
+- `bindings[].publishPipelineUrl` writes a `publish` action beside `select`
+  (no method or path). On a binding that already exists the Job adds or
+  repoints that one action with a PUT of the whole record; every other write is
+  still create-only. Needs registry 0.5.0+.
+


under 0.1.2 only

kelvinprabhu · 2026-10-27T10:33:02Z

            binding = f'{b["participantId"]}|{b["capability"]}'
            # actions is a list, not a map: the registry treats every nested
            # object as an entity and injects an osid, which a map cannot carry.
+            actions = [{"action": "select",


keep it as before |. it looks complicated |

…y the seed Review follow-up on #96: - ProviderSchema: method, path and the MappingPath ref stay required for every action. publish joins the Action enum and MappingPath also accepts a <...>/publish/<source>.yaml pipeline URL; the allOf and PublishMappingPath are gone. - registry-seed 0.1.2: the select action is written as before, with the publish action (POST /publish) appended when publishPipelineUrl is set. ensure_publish_action does its own PUT; values.yaml is unchanged. Refs #77

The crawler executes the pipeline a publish action names, so its URL must not be fetchable over plain http. Beckn action mappings keep accepting http or https as before. Refs #77

ProviderSchema.json is the chart copy from #96: publish joins the Action enum and MappingPath also accepts an https <...>/publish/<source>.yaml pipeline URL, while method, path and mappings stay required for every action. setup.py now writes the publish action as POST /publish, both on a new binding and when it adds or repoints the action on an existing one. Refs #77

The run log must not live on discovery's database: say so, with the shared postgres cluster as the place for it, and map the pipeline's Agmarknet inputs from the provider's upstream Secret instead of copying them. The CHANGELOG names registry-seed 0.1.2, the version #96 ships. Refs #77

kelvinprabhu · 2026-10-28T03:10:21Z

Dev rollout: OpenAgriNet/infra-automation#19 (PR OpenAgriNet/infra-automation#20) sets publishPipelineUrl on the agmarknet binding. No ordering constraint: the current registry-seed ignores the field.

…ntries Refs #77

Refs #77

kelvinprabhu mentioned this pull request Oct 27, 2026

feat(adapter-service,registry,registry-seed): enable the catalog crawler for publishing catalogues #92

Open

kelvinprabhu commented Oct 27, 2026

View reviewed changes

kelvinprabhu added 2 commits October 27, 2026 16:14

fix(registry): require https for publish pipeline URLs

3b74d28

The crawler executes the pipeline a publish action names, so its URL must not be fetchable over plain http. Beckn action mappings keep accepting http or https as before. Refs #77

kelvinprabhu mentioned this pull request Oct 27, 2026

feat(quick-start): enable the catalog crawler for publishing catalogues #93

Open

kelvinprabhu mentioned this pull request Oct 28, 2026

Catalog crawler: enabling it for publishing catalogues (follow-up to OpenAgriNet/network-adapter#54) #77

Open

chore(registry,registry-seed): drop the version bumps and changelog e…

55c03c3

…ntries Refs #77

kelvinprabhu added a commit that referenced this pull request Oct 28, 2026

docs(adapter-service): name #96 rather than registry chart versions

81c8a45

Refs #77

Base automatically changed from development to release-0.2.0 November 2, 2026 06:48

Navigation Menu

Repository navigation

feat(registry,registry-seed): admit and seed the catalog crawler's publish action - #96

feat(registry,registry-seed): admit and seed the catalog crawler's publish action#96
kelvinprabhu wants to merge 5 commits into
release-0.2.0from
feat/77-catalog-crawler-registry-publish-action

kelvinprabhu commented Oct 27, 2026 •

edited

Loading

Uh oh!

kelvinprabhu left a comment

Uh oh!

kelvinprabhu Oct 27, 2026

Uh oh!

kelvinprabhu Oct 27, 2026

Uh oh!

kelvinprabhu Oct 27, 2026

Uh oh!

kelvinprabhu Oct 27, 2026

Uh oh!

kelvinprabhu Oct 27, 2026

Uh oh!

kelvinprabhu Oct 27, 2026

Uh oh!

kelvinprabhu commented Oct 28, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

kelvinprabhu commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Objective

Solution

Verification

Not done

Uh oh!

kelvinprabhu left a comment

Choose a reason for hiding this comment

Uh oh!

kelvinprabhu Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

kelvinprabhu Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

kelvinprabhu Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

kelvinprabhu Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

kelvinprabhu Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

kelvinprabhu Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

kelvinprabhu commented Oct 28, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

kelvinprabhu commented Oct 27, 2026 •

edited

Loading