Repository navigation
ci(ai-review): grant checks: read so reviewers see SonarQube findings - #3958
Merged
Merged
Conversation
The shared AI review gate now reads the SonarQube check run on the PR head (OpenC3/.github#14). A called workflow cannot exceed its caller's permissions, so the caller must grant checks: read. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3958 +/- ##
=======================================
Coverage 80.11% 80.12%
=======================================
Files 901 901
Lines 68370 68370
Branches 2699 2699
=======================================
+ Hits 54773 54779 +6
+ Misses 12929 12926 -3
+ Partials 668 665 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The AI review of #3942 missed the two SonarQube findings that failed the quality gate. The shared gate only read GitHub Actions runs, and SonarQube reports as a check run from its own GitHub App. OpenC3/.github#14 makes the gate collect SonarQube findings and has the reviewers fix them.
What changes
Adds
checks: readto the permissions this workflow grants the shared AI review workflow. A called workflow can't get more permission than its caller gives it, so without this the gate can't read the SonarQube check run. It then only warns and leaves the findings out.This is safe to merge before or after OpenC3/.github#14. The extra permission is read-only and does nothing until the shared workflow uses it.
🤖 Generated with Claude Code