Repository navigation
Conversation
… data out of CVT A protocol-identified packet for an unmapped target, or a stored packet with an unknown identity, is now warned about and identified by content. Stored packets that cannot be identified no longer update the UNKNOWN CVT entry. Python logs the unknown hex prefix in uppercase and writes stored as "true"/"false" like Ruby. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4000 +/- ##
==========================================
+ Coverage 80.06% 80.16% +0.10%
==========================================
Files 901 901
Lines 68370 68449 +79
Branches 2699 2714 +15
==========================================
+ Hits 54738 54874 +136
+ Misses 12976 12906 -70
- Partials 656 669 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
2 tasks done
Resolves ty unresolved-attribute errors on self.interface, which is typed as possibly None, in the new pre-identified telemetry check. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Type the microservice interface as non-optional, require scope on the handler threads (matching Ruby), and align the shutdown override with Microservice.shutdown. Also fixes router reconnect with new params writing to an undefined interface_model and logging the bound connection_string method instead of its value. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
InterfaceMicroservice#handle_packet(Ruby and Python):tlm_target_names, or names a packet that doesn't exist, the interface now logsReceived unknown identified telemetry: TGT PKTand identifies the packet by content against the mapped targets. Before, any known target was accepted even if it wasn't mapped. Stored packets with an unknown identity were silently published as UNKNOWN, with no warning and no fallback.update!orCvtModel.set.TelemetryTopic.write_packetwritesstoredas"true"/"false". All readers use the case-insensitivehandle_true_false.Fixes the IF-CFG-001, IF-TLM-001, IF-TLM-002 and IF-TLM-003 deviations in
architecture/specs/interface-microservice.yaml.Test plan
bundle exec rspec spec/topics spec/microservices/interface_microservice_spec.rb(76 examples, 0 failures). The 3 new examples fail on the old code.uv run pytest test/topics test/microservices/test_interface_microservice.py test/microservices/test_decom_microservice.py(85 passed). The 3 new handle_packet tests and the newtest_telemetry_topic.pyfail on the old code.ruff check/ruff format --check🤖 Generated with Claude Code