Repository navigation
AI review fixes for #3998 - #4032
Merged
ryanmelt merged 1 commit intoOct 10, 2026
Merged
Conversation
- openc3/python/openc3/packets/packet.py:1351 - SonarQube python:S7504 flagged the `list()` call used to delete keys during iteration, and the code changed the caller's `params` dict in place, because the Python `given_values` setter does not copy (Ruby's setter clones). Fix: build a new filtered dict instead, and use a set to look up the obfuscated names. This keeps Python consistent with Ruby. - openc3/python/test/packets/test_packet.py:1914 - The new test copied the setup of test_obfuscates_a_single_uint_item almost line for line, which added to new_duplicated_lines_density (3.3 against a limit of 3). Fix: moved the given_values assertion, with mixed-case keys, into the existing test and removed the duplicate. - openc3/spec/packets/packet_spec.rb:1856 - Same duplication in the Ruby spec. Fix: moved the given_values assertion into the existing 'obfuscates a single UINT item' spec and removed the duplicate. AI-Review-Bot: true AI-Review-Run: 38018577445
2 tasks done
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## fix/obfuscate-given-values #4032 +/- ##
==============================================================
- Coverage 80.14% 80.12% -0.03%
==============================================================
Files 901 901
Lines 68378 68376 -2
Branches 2646 2646
==============================================================
- Hits 54804 54788 -16
- Misses 12907 12921 +14
Partials 667 667
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the AI review of #3998 at 4f02be2. Merge this PR to apply them to
fix/obfuscate-given-values; the review summary is on #3998.