Skip to content

ci(security): use v3.6 hashes for OpenCHAMI reusable workflows; pin all actions to hashes - #134

Merged
synackd merged 1 commit into
mainfrom
ci/fix-security
Sep 2, 2026
Merged

synackd merged 1 commit into
mainfrom
ci/fix-security

Conversation

@synackd

@synackd synackd commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Description

The Security workflow referenced three reusable workflows (govulncheck, dependency-review and lint-workflows) at the v3.2 tag of the OpenCHAMI/github-actions repository. The v3.2 tag does not contain these files, which caused the workflow parsing step to fail with a "failed to fetch workflow: workflow was not found" error.

Update the uses: lines in .github/workflows/security.yaml to point to the commit hash represented by the v3.6 tag for all three jobs, ensuring security compliance with immutable hashes and updating the version to the proper one containing the expected files.

Fixes failing job: https://github.com/OpenCHAMI/cloud-init/actions/runs/33657985952

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass
  • I have updated the relevant documentation (CLI examples, man pages, README, other docs, etc.)
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
    • Each new/modified source file has SPDX copyright and license headers
    • Any non-commentable files include a <filename>.license sidecar
    • All referenced licenses are present in the LICENSES/ directory

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Dependency update
  • Build system/CI

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Comment thread .github/workflows/security.yaml Fixed
Comment thread .github/workflows/security.yaml Fixed
Comment thread .github/workflows/security.yaml Fixed
Comment thread .github/workflows/security.yaml Fixed
Comment thread .github/workflows/security.yaml Fixed
@synackd

synackd commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

actionlint job is failing because the hash in the OpenCHAMI GitHub action is incorrect. Fixed in OpenCHAMI/github-actions#17.

@synackd synackd changed the title ci(security): move permissions to top‑level and remove illegal per‑job permissions ci(security): use v3.5 hashes for reusable workflows Sep 2, 2026
@synackd
synackd marked this pull request as ready for review September 2, 2026 17:55
The Security workflow referenced three reusable workflows (govulncheck,
dependency-review and lint-workflows) at the v3.2 tag of the
OpenCHAMI/github-actions repository. The v3.2 tag does not contain these
files, which caused the workflow parsing step to fail with a "failed to
fetch workflow: workflow was not found" error.

Update the `uses:` lines in .github/workflows/security.yaml to point to
the commit hash represented by the v3.6 tag for all three jobs, ensuring
security compliance with immutable hashes and updating the version to
the proper one containing the expected files.

Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
@synackd synackd changed the title ci(security): use v3.5 hashes for reusable workflows ci(security): use v3.6 hashes for reusable workflows Sep 2, 2026
@synackd synackd changed the title ci(security): use v3.6 hashes for reusable workflows ci(security): use v3.6 hashes for OpenCHAMI reusable workflows; pin all actions to hashes Sep 2, 2026
@synackd
synackd enabled auto-merge (squash) September 2, 2026 18:20
@synackd
synackd merged commit 991f68f into main Sep 2, 2026
14 checks passed
@synackd
synackd deleted the ci/fix-security branch September 2, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants