Repository navigation
Revert "Support special characters in job names" - #662
Closed
hanna-paasivirta wants to merge 1 commit into
Closed
hanna-paasivirta wants to merge 1 commit into
hanna-paasivirta wants to merge 1 commit into
Conversation
Collaborator
|
@hanna-paasivirta what is behind this one? I cannot tell from the revert whether you hit a problem with the unicode work or whether it was to unblock something else. Happy to fix whatever it is, I would just rather know what broke before I touch it. |
Contributor
Author
|
@elias-ba I understood from standup that @josephjclark still wanted to review it so I re-opened it. I'm ok with merging it though. |
Collaborator
|
Oh - not for my sake, this is fine, I'm happy to merge :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #658