Repository navigation
report capacity - #1048
Merged
Merged
report capacity#1048
Conversation
josephjclark
requested changes
Oct 6, 2025
josephjclark
left a comment
josephjclark
left a comment
Collaborator
There was a problem hiding this comment.
Cool - I've left a few comments, mostly stylistic but those t.pass() assertions will make your tests pass even if you comment out the actual feature code.
Member
Author
|
@josephjclark , simplified significantly and (i think) addressed all your requests |
josephjclark
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When joining the worker_channel, this makes the worker report their configured run capacity.
It's used by OpenFn/lightning#3725 so that Lightning can check to see how much capacity exists (connected workers * individual worker capacity) when it wants.
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Release branch checklist
Delete this section if this is not a release PR.
If this IS a release branch:
pnpm changeset versionfrom root to bump versionspnpm installpnpm changeset tagto generate tagsgit push --tagsTags may need updating if commits come in after the tags are first generated.