Skip to content

feat: ignore objects for lazy state - #1054

Merged
doc-han merged 2 commits into
ignore-top-object-add-importfrom
ignore-top-level-objects-lazy-state
Oct 8, 2025
Merged

doc-han merged 2 commits into
ignore-top-object-add-importfrom
ignore-top-level-objects-lazy-state

Conversation

@doc-han

@doc-han doc-han commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

Short Description

A one or two-sentence description of what this PR does.

Fixes #

Implementation Details

A more detailed breakdown of the changes, including motivations (if not provided in the issue).

QA Notes

List any considerations/cases/advice for testing/QA here.

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

Release branch checklist

Delete this section if this is not a release PR.

If this IS a release branch:

  • Run pnpm changeset version from root to bump versions
  • Run pnpm install
  • Commit the new version numbers
  • Run pnpm changeset tag to generate tags
  • Push tags git push --tags

Tags may need updating if commits come in after the tags are first generated.

@github-project-automation github-project-automation Bot moved this to New Issues in Core Oct 8, 2025
@doc-han

doc-han commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator Author

@josephjclark any ideas on how to test this?

@josephjclark

Copy link
Copy Markdown
Collaborator

@doc-han in a unit test you could simply assert that this:

const x = { x: $.data }

Does not transform the code in any way

@josephjclark

Copy link
Copy Markdown
Collaborator

@doc-han I wasn't expecting this in a separate PR - once you're done with the test can you consolidate them into a single PR with appropriate changesets?

I'll test them together against my test file and see if there's an improvement in performance

@doc-han
doc-han changed the base branch from main to ignore-top-object-add-import October 8, 2025 16:52
@doc-han
doc-han marked this pull request as ready for review October 8, 2025 16:53
@doc-han
doc-han merged commit 634783e into ignore-top-object-add-import Oct 8, 2025
1 of 2 checks passed
@github-project-automation github-project-automation Bot moved this from New Issues to Done in Core Oct 8, 2025
@josephjclark
josephjclark deleted the ignore-top-level-objects-lazy-state branch October 8, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants