Repository navigation
Ameliorate crash-loop during worker startup - #1088
Merged
Merged
Conversation
Collaborator
|
Ok this should work well:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
Workers were failing intermittently on startup in GKE with "Invalid worker path" errors. The worker would crash and retry several times before eventually succeeding.
Fixes #1016
Implementation Details
Root Cause
The worker validation happens immediately after engine initialization with only a 5-second timeout. In containerized environments, child process initialization can be slower due to:
Solution
Testing
QA Notes
@josephjclark , what's up with my pnpm-lock? Why such a big diff when I run
pnpm install? This looks like the thing that causes all the other changes, if i had to guess: https://github.com/OpenFn/kit/pull/1088/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR470AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Release branch checklist
Delete this section if this is not a release PR.
If this IS a release branch:
pnpm changeset versionfrom root to bump versionspnpm installpnpm changeset tagto generate tagsgit push --tagsTags may need updating if commits come in after the tags are first generated.