Repository navigation
Runtime memory Metrics - #1103
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
This PR adds two new tools for tracking memory usage in the worker:
profileto true, the runtime will poll memory usage while it's running and log the peak stack it detects. This should be a lot more accurate than the old memory analysis, but might have a small impact on performance (probably negligible)Profiling is disabled by default. Set
PROFILE=trueto enable it.I have not added profiling options to the CLI, and I have not added an integration test. I'm trying to keep the cost of this down.
Fixes #1100
Fixes #1101
Fixes #1022 (I was in the neighbourhood)
Old logs
New Logs
Claim logs
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy