Repository navigation
Async child process kill - #1107
Merged
Merged
Conversation
* remove errant log * version: worker@1.19.1
The pool.destroy() method was calling worker.kill() to send SIGTERM signals but not waiting for child processes to actually terminate. This caused test timeouts as assertions checked child.killed immediately after destroy(), before the OS had processed the termination signals.
…1106) * Remove errant log (#1104) * remove errant log * version: worker@1.19.1 * fix(engine-multi): await child process termination in pool.destroy() The pool.destroy() method was calling worker.kill() to send SIGTERM signals but not waiting for child processes to actually terminate. This caused test timeouts as assertions checked child.killed immediately after destroy(), before the OS had processed the termination signals. --------- Co-authored-by: Joe Clark <jclark@openfn.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging #1106 for release