Repository navigation
Explicit --checkout/--no-checkout beats OPENFN_NO_CHECKOUT_AFTER_DEPLOY - #1589
Merged
Merged
Conversation
josephjclark
force-pushed
the
release/next
branch
from
October 15, 2026 15:30
4597116 to
5b42eff
Compare
josephjclark
force-pushed
the
ofn-4763-checkout-flag-precedence
branch
from
October 15, 2026 15:31
0914f9e to
51191c3
Compare
josephjclark
approved these changes
Oct 15, 2026
josephjclark
added a commit
that referenced
this pull request
Oct 23, 2026
* Explicit --checkout/--no-checkout beats OPENFN_NO_CHECKOUT_AFTER_DEPLOY (#1589) * fix(cli): explicit --checkout/--no-checkout beats OPENFN_NO_CHECKOUT_AFTER_DEPLOY * update tests --------- Co-authored-by: Joe Clark <jclark@openfn.org> * Fix flaky tests maybe (#1591) * run worker integratio n tests wuth clean new instances each time * worker: add immediate destroy for unit tests * Track workflow renames (#1596) * deprecate the id field being written to workflow.yaml * track workflow uuid in checkout.yaml * track workflow UUIDs when loading from fs * add helper to match workflows on merge * hookup workflow tracking to deploy * impove diff for users upon a workflow rename * clarifying comments on test files * couple of tests * add more basic sync tests * new tests * restructure sync integration tests * add step rename tests * cli: use env var to skip no confirm * refactor tests for cleaner commands# * enable workflow tracking on rename * new test * Fix cross-project deploy: make the target match the local project (#1588) * Fix cross-project deploy and add --remove-unmapped to project deploy Deploying a workspace to a different project now treats every local workflow as a merge candidate, instead of only those changed since the workspace's own last sync. --remove-unmapped sends delete entries for target workflows that don't exist locally. * Mirror the local project when deploying to a different project Drop --remove-unmapped: target-only workflows are removed by default when the target UUID differs, and need --force when there is no confirmation prompt. * variable rename * new suite of cross-project deploy tests --------- Co-authored-by: Joe Clark <jclark@openfn.org> * fix(project): preserve workflows in bracketed paths (#1592) * simplify test * versions --------- Co-authored-by: Midigo Frank <39288959+midigofrank@users.noreply.github.com> Co-authored-by: Ky Jahn Smith <kyjahntsmith@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
An explicit
--checkoutor--no-checkoutonproject deploynow overridesOPENFN_NO_CHECKOUT_AFTER_DEPLOY. The env var only sets the default.Fixes OFN-4763
Implementation Details
checkouthad a yargsdefault: true, soensure()couldn't tell an explicit--checkoutfrom the default and setcheckout = falsewhenever the env var was'true'.ensure()resolves the value from the env var only when the flag wasn't passed.QA Notes
deploy-options.test.ts(5 cases, parsing the real command through yargs): env=true +--checkoutfailed before the fix; the rest lock in existing behaviour.--helpno longer shows[default: true]for--checkout; the description still says checkout is the default.AI Usage