[EstebanSantiag0]

Description

Adds LED support data for the ASUS TUF Gaming A16 FA607NUG (layout_name: fa507).

Without an entry asusd logs the aura_support.ron file has no entry for this model: FA607NUG, tuf. Using a default and only offers Static; asusctl aura effect breathe ... fails with org.freedesktop.DBus.Error.NotSupported: The Aura effect is not supported.

The keyboard is driven through the existing asus-wmi TUF sysfs path (asus::kbd_backlight, aura type "tuf"). The entry lists Static, Breathe, RainbowCycle and Pulse, the same set as the FA608PM/WI/WV entries. Tested by putting exactly this entry in /etc/asusd/asusd_user_ledmodes.ron and restarting asusd: asusctl aura effect static, breathe, rainbow-cycle and pulse are accepted and all four were confirmed visually on the keyboard.

Fixes #429

Tested Hardware & Environment

• ASUS Laptop Model: TUF Gaming A16 FA607NUG (BIOS FA607NUG.303)
• Linux Distribution: Arch Linux, asusctl 6.4.0
• Kernel Version: 7.2.4-arch1-2

Verification and testing:

• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas (n/a: data-only change)
• I have made corresponding changes to the documentation (n/a)
• My code follows the style guidelines of this project (cargo fmt --all -- --check) (n/a: no Rust changes)
• My changes generate no new warnings (cargo clippy --all -- -D warnings/cargo check --all-targets) (n/a: no Rust changes)
• New and existing unit tests pass locally with my changes (cargo test -p rog_aura, which parses aura_support.ron)
• Cranky with 0 warning (cargo cranky) (n/a: no Rust changes)

🤖 Generated with Claude Code

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Repository UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 2b7ec91d-a835-43cb-a32f-c9ac4400922a

Commits

Reviewing files that changed from the base of the PR and between 13cdaa9 and b4230d4.

Files selected for processing: 1

• rog-aura/data/aura_support.ron

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Recent review details

Additional comments: 1

rog-aura/data/aura_support.ron: 1

38-46: LGTM!

📝 Summary

Summary by CodeRabbit

• New Features
  • Added Aura lighting support for the FA607NUG, including static, breathing, rainbow cycle, and pulse effects, plus keyboard power control.

The Aura support data now includes an FA607NUG entry. It uses the fa507 layout and lists Static, Breathe, RainbowCycle, and Pulse modes.

Changes: FA607NUG Aura Support

Layer / File(s)	Summary
Device configuration rog-aura/data/aura_support.ron	Adds FA607NUG with the fa507 layout, four basic modes, no basic zones or advanced type, and keyboard power control.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Feature · Severity of issue fixed: Medium

Possibly related PRs

• OpenGamingCollective/asusctl#415: Changes effect speed handling for TUF keyboard devices, which includes the TUF path used by the newly configured FA607NUG.

Suggested labels: rog-aura, enhancement

Suggested reviewers: scardracs, ghoul4500

Merge Risk: Minimal · up to b4230

No actionable merge-blocking risk remains for this support-data change.

Pre-merge checks: 4

Check name	Status	Explanation
Description check		The description clearly explains the FA607NUG Aura support change, references issue #429, documents the tested hardware and environment, and records verification results. It covers the required templa…
Title check		The title is concise, specific, and accurately describes the main change: adding Aura support for the TUF Gaming A16 FA607NUG.
Linked Issues check		Issue #429 requires one FA607NUG entry in aura_support.ron. The reviewed file contains that entry with product_id: "", layout_name: "fa507", `basic_modes: [Static, Breathe, RainbowCycle, Pulse…
Out of Scope Changes check		The available PR evidence shows one data-file change in rog-aura/data/aura_support.ron. The change adds the FA607NUG Aura support entry requested by issue #429. No unrelated source, documentation,…

Full details: Description check

Explanation

The description clearly explains the FA607NUG Aura support change, references issue #429, documents the tested hardware and environment, and records verification results. It covers the required template sections.

Full details: Linked Issues check

Explanation

Issue #429 requires one FA607NUG entry in aura_support.ron. The reviewed file contains that entry with product_id: "", layout_name: "fa507", basic_modes: [Static, Breathe, RainbowCycle, Pulse], basic_zones: [], advanced_type: r#None, and power_zones: [Keyboard]. These fields match the issue requirements. The PR summary also reports cargo test -p rog_aura success.

Full details: Out of Scope Changes check

Explanation

The available PR evidence shows one data-file change in rog-aura/data/aura_support.ron. The change adds the FA607NUG Aura support entry requested by issue #429. No unrelated source, documentation, or behavior changes are shown.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}