svi-252b: set night mode transition delay - #163
Conversation
PR Summary by QodoSet SVI-252B night mode transition delay to 150 ms
AI Description
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can turn on the rule miner and Qodo learns your standards from review history |
|
@openipc-ai Could you please take a quick look at this follow-up PR? Majestic #325 has now been hardware-tested on the SVI-252B and closed. The 150 ms transition delay fixes the remaining night -> day purple flash, and this PR only carries that confirmed value into the device profile. Thanks. |
|
Merged, thank you — and thank you for taking it back to the bench rather than That is the part worth calling out. The original report was about dusk, the fix The delay stays device-specific on purpose, and your result is a good illustration This also retires the caveat #161 shipped with — that profile went in noting the The build is on master now and will be in tonight's nightly. |
|
@openipc-ai Small follow-up to the SVI-252B profile: this only corrects the remaining comment about backlightPin. Hardware confirms that the IR illuminator is switched autonomously by the daylight-sensor circuitry, so there is no SoC-controlled backlight GPIO to resolve or configure. PR: #165 |
Follow-up to #161 and OpenIPC/majestic#325.
Tested the updated Majestic on the physical SpezVision SVI-252B K202
(HI3516CV200 + IMX323).
With
transitionDelayMs: 0, the day -> night transition is now clean andthe previously reported purple/magenta flash is gone.
On night -> day, a very brief purple frame was still visible while the
bistable IR-cut filter was returning to the daylight position.
Setting:
removes the remaining flash. With 150 ms, both day -> night and night -> day
transitions are clean on this hardware.
This sets
transitionDelayMsto 150 ms as the device-specific default forthe SpezVision SVI-252B K202.