Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,14 @@ BR2_PACKAGE_MAJESTIC_FONTS=y
BR2_PACKAGE_MAJESTIC_WEBUI=y
BR2_PACKAGE_MAJESTIC=y
BR2_PACKAGE_MBEDTLS_OPENIPC=y
# Disabilita i driver FPV ingombranti che non usi a banco per fare spazio
# BR2_PACKAGE_RTL88X2EU_OPENIPC is not set
# BR2_PACKAGE_RTL8812AU_OPENIPC is not set

# Mantieni assolutamente attivo il driver Morse Micro per l'HaLow
BR2_PACKAGE_MORSE_MICRO=y
BR2_PACKAGE_OPUS_OPENIPC=y
BR2_PACKAGE_OPUS_OPENIPC_FIXED_POINT=y
BR2_PACKAGE_RTL88X2EU_OPENIPC=y
BR2_PACKAGE_RTL8812AU_OPENIPC=y
BR2_PACKAGE_SIGMASTAR_OSDRV_INFINITY6E=y
BR2_PACKAGE_VTUND_OPENIPC=y
BR2_PACKAGE_WIFIBROADCAST_NG=y
Expand Down
4 changes: 4 additions & 0 deletions morse-micro/Config.in
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
config BR2_PACKAGE_MORSE_MICRO

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Firmware lacks its wireless driver 📘 Rule violation ≡ Correctness

copy_extra_packages scans only children of package/, but the new Config.in and
morse-micro.mk are placed in the repository-root morse-micro/ directory. During RunCam device
builds, BR2_PACKAGE_MORSE_MICRO=y has no imported definition, so neither package file is copied or
sourced and the intended HaLow replacement for the removed Realtek drivers does not reach the target
firmware.
Agent Prompt
## Issue description
The Morse Micro package is outside the builder-local `package/` directory, so the builder does not copy or register it and the RunCam device defconfig cannot build its wireless driver.

## Fix Focus Areas
- morse-micro/Config.in[1-4]
- morse-micro/morse-micro.mk[1-12]
- builder.sh[104-115]

## Recommended Fix
Move the complete `morse-micro` directory to `package/morse-micro/`, preserving the names and contents of `Config.in` and `morse-micro.mk`. This lets `copy_extra_packages` copy the directory into `general/package` and automatically append its `Config.in` source entry before processing the device defconfig.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

bool "morse-micro"
help
Morse Micro Wi-Fi HaLow driver for OpenIPC
12 changes: 12 additions & 0 deletions morse-micro/morse-micro.mk
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
################################################################________________
#
# morse-micro
#
################################################################________________

MORSE_MICRO_VERSION = master

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remediation recommended

2. Pinned builds fetch changing driver code 🐞 Bug ☼ Reliability

MORSE_MICRO_VERSION names the mutable master branch rather than an immutable revision. Fresh
builds—and even workflows using OPENIPC_FW_REV to pin firmware for regression bisection—can
therefore compile different driver code from the same builder and firmware commits.
Agent Prompt
## Issue description
The package fetches the moving upstream `master` branch, making otherwise pinned builds depend on whichever driver revision is current at build time.

## Fix Focus Areas
- morse-micro/morse-micro.mk[7-9]
- builder.sh[121-130]

## Recommended Fix
Replace `MORSE_MICRO_VERSION = master` with a tested immutable upstream commit SHA or release tag. Update that revision explicitly when adopting newer driver code.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

MORSE_MICRO_SITE = https://github.com/morsemicro/mm-wifi-linux
MORSE_MICRO_SITE_METHOD = git

$(eval $(kernel-module))
$(eval $(generic-package))