Add Smitch 360 PTZ (HI3518EV300, JXF23, RTL8188FU, NOR 16MB) - #82
Conversation
|
Thanks for this, and sorry it sat so long. It is in good shape — reviewed against current master. Good news first: you no longer need a What checks out
Three small things before merge
Rebase on master with those and CI will tell us whether it builds. |
openipc-ai
left a comment
There was a problem hiding this comment.
Marking this changes-requested so it shows up as such in the queue. Nothing new — the same three items from my review above are still outstanding:
- Drop
BR2_PACKAGE_JSONFILTER=yfrom the defconfig (#128 removed it from all 97 defconfigs after firmware/#2304). - Drop the unrelated README wording change on the "Create firmware with built-in credentials" heading. The device-table row is welcome, keep that.
customizer.shis missing its trailing newline.
The branch still merges cleanly, so no rebase is needed — push those three and CI will build the device.
…ewline BR2_PACKAGE_JSONFILTER was removed from every defconfig in OpenIPC#128 after firmware/#2304; it drags in libubox for nothing unless the device enables uqmi-openipc or wifibroadcast-ng, and this board enables neither. The repack.sh section heading was reworded in passing; that is unrelated to adding a device, so it goes back to what master has. The device-table row stays. customizer.sh was missing its trailing newline.
cbacc14 to
dc8ef20
Compare
|
Picking this back up rather than letting it age out — the device work was fine,
I also rebased onto current master. When I last looked the branch still merged Note this was a force-push, so if you have a local copy of the branch, reset to
|
The defconfig referenced $(BR2_EXTERNAL)/scripts/ubifs/ubinize_hisilicon.cfg,
which is not in the firmware tree — the two devices that use that name each
ship their own copy under general/scripts/ubifs/, and this profile did not.
The build got as far as rootfs.ubifs and then died with
sed: can't read .../general/scripts/ubifs/ubinize_hisilicon.cfg
The UBI target itself is wanted: CI publishes both a -nor.tgz and a -nand.tgz
for these ultimate profiles, and the nand repack consumes rootfs.ubi.
Switched to the in-tree ubinize.cfg, which is what both hi3518ev200 ultimate
boards use. It suits the nand repack better than the hisilicon variant, which
adds a kernel volume while the repack already passes uImage separately. The NOR
image is unaffected either way — that path repacks uImage plus rootfs.squashfs.
|
Merged. One more fix was needed beyond the three above, worth writing down The first build failed late, after generating
Worth knowing that the UBI block is not dead weight on a NOR board, so deleting I switched it to the in-tree Both now build with room to spare: NOR rootfs 6828/8192 KB, NAND rootfs.ubi If the motors get working, a follow-up updating the README status would be |
Device details
Notes
rtl8188fu-hi3518ev300-t5810hct-m02already merged in firmware repo: add wifi support for t5810hct-m02 board firmware#1373
Status
video-yes, wifi-yes, motors-no