Conversation
Dead since the table metadata probe switched to `WHERE 1 = 0`. Dropped the REST parameter, the Drivers dialog column, and the dbdrivers.xml attribute. `DriverInfo.selectLimit` is retained as a deprecated no-op: the field still has to exist for previously saved driver lists to deserialize, and the constructors keep outside callers building. It no longer participates in equals, so the dialog does not report a phantom change when loading an old config. Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
mgaffigan
requested review from
a team,
NicoPiel,
gibson9583,
jonbartels,
kayyagari,
kpalang,
pacmano1 and
ssrowe
September 24, 2026 16:04
pacmano1
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dead since the table metadata probe switched to
WHERE 1 = 0. Dropped the REST parameter, the Drivers dialog column, and the dbdrivers.xml attribute.DriverInfo.selectLimitis retained as a deprecated no-op: the field still has to exist for previously saved driver lists to deserialize, and the constructors keep outside callers building. It no longer participates in equals, so the dialog does not report a phantom change when loading an old config.Parameter can be removed without breaking users - extra parameters are ignored. I can't find any plugins that use the call directly, and it doesn't seem likely that one would, so that parameter was dropped without a deprecated overload.
Closes #461