Skip to content

Allows toon ramp modification of shadow zone #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jlanz wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −2
Open

Allows toon ramp modification of shadow zone #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/rendering/shading/bsdf/npr/BsdfToon.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,14 @@ ToonBsdfLobe::eval(const BsdfSlice &slice,
float cosThetaWi = dot(N, wi);

if (pdf != NULL) {
*pdf = max(cosThetaWi, 0.0f) * sOneOverPi;
// Use sEpsilon as the floor rather than 0 for shadow-side directions
// (cosThetaWi <= 0). A zero pdf would cause isSampleInvalid() to
// discard the light sample entirely, suppressing the shadow-zone ramp
// contribution added in MOONSHINE-2049. This lobe never
// importance-samples the back hemisphere, so a near-zero positive pdf
// is semantically correct: it gives the light sample near-unity MIS
// weight for those directions, which is the desired behavior.
*pdf = max(cosThetaWi, sEpsilon) * sOneOverPi;
}

// Note: we assume this lobe has been setup with a OneMinus*Fresnel
Expand Down
9 changes: 8 additions & 1 deletion lib/rendering/shading/ispc/bsdf/npr/BsdfToon.ispc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,14 @@ ToonBsdfLobe_eval(const varying BsdfLobe * uniform lobe,
const float cosThetaWi = dot(N, wi);

if (pdf != NULL) {
*pdf = max(cosThetaWi, 0.0f) * sOneOverPi;
// Use sEpsilon as the floor rather than 0 for shadow-side directions
// (cosThetaWi <= 0). A zero pdf would cause isSampleInvalid() to
// discard the light sample entirely, suppressing the shadow-zone ramp
// contribution added in MOONSHINE-2049. This lobe never
// importance-samples the back hemisphere, so a near-zero positive pdf
// is semantically correct: it gives the light sample near-unity MIS
// weight for those directions, which is the desired behavior.
*pdf = max(cosThetaWi, sEpsilon) * sOneOverPi;
}

// Note: we assume this lobe has been setup with a OneMinus*Fresnel
Expand Down