fix(trajectories): preserve supplied Messages fields in saved traject… - #947
Open
shobhitagnihotri69 wants to merge 1 commit into
Open
shobhitagnihotri69 wants to merge 1 commit into
shobhitagnihotri69 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves provider-supplied fields and explicit nulls on
MessagesExchange(Anthropic Messages API) responses when saving trajectories, mirroring the exact behavior introduced forResponsesExchangein #938.Context & Implementation
In #938 (@bradhilton),
ResponsesExchangeintroduced a custom@pydantic.field_serializer("response")withexclude_unset=Trueso that provider omissions and explicit nulls survive trajectory serialization and replay.MessagesExchangesuffered from the exact same defect:exclude_unset=True, saving Anthropic trajectories materialized unsupplied default fields (container: None,stop_details: None, etc.), cluttering serialized tapes and breaking round-trip equality.exclude_defaults=True, provider-supplied explicit nulls (e.g.stop_sequence: None) were dropped.Changes:
@pydantic.field_serializer("response")withexclude_unset=TruetoMessagesExchangeinsrc/art/trajectories/__init__.py.tests/unit/trajectories/test_messages_serialization.pycovering round-trips, explicit nulls, nested includes/excludes, and legacy tape preservation.Verification
uv run pytest tests/unit/trajectories/test_messages_serialization.py tests/unit/trajectories/test_responses_serialization.py: 50 passed in 1.28s.uv run ruff check src/art/trajectories/__init__.py tests/unit/trajectories/test_messages_serialization.py: All checks passed.