Repository navigation
fix(deps): accept ovos-plugin-manager 3 - #1029
Conversation
Remove the <3.0.0 ceiling on ovos-plugin-manager and keep the floor. The unit suite passes unchanged on OPM 3.1.0a1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Beep! Your PR results are served. 🍽️I've aggregated the results of the automated checks for this PR below. 📚 DocsAnother check completed successfully! 🏁 ✅ All required documentation files present. ✅ 📡 Channel Compat — stableA quick update on the progress of your PR checks. 📈 🚧 Channel unresolvable with this checkout — the repo's dependency floors exceed what the channel pins (fleet finding; see the install log). Constraints: https://raw.githubusercontent.com/OpenVoiceOS/OpenVoiceOS/main/constraints-stable.txt 🌍 Locale BuildEvaluating the overall impact of your changes. 📈 ✅ Locale properly configured (66 files, 19 languages) Locale directories found:
Localization coverage:
pyproject.toml: ✅
Build manifest: ✅ 35 locale files included in package 📋 Repo HealthChecking for any potential repo regressions. 🔄 ✅ All required files present. Latest Version: ✅ 🔒 Security (pip-audit)Ensuring our cross-site scripting defenses are up. 🛡️ ✅ No known vulnerabilities found (113 packages scanned). 📊 CoverageEnsuring our safety net is wide enough. 🕸️ Files below 80% coverage (10 files)
Full report: download the 🔌 Plugin DetectionEnsuring the OpenVoiceOS Plugin Manager can find this gem. 💎 ❌ Plugin Status: ERRORS (1) Plugin Info:
OPM Detection:
Entry Point Validation:
⊘ No Issues:
⚖️ License CheckVerifying the origin of all contributed code. 🌍 ✅ No license violations found.
Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 🔌 Skill Tests (ovoscope)Testing the skill's 'peripheral vision' (aka broad intents). 👁️ ✅ 43/43 passed ✅ TestActiveHandlersOnlyIsNotPolled — 1/1 🚌 Bus CoverageEnsuring the skill's internal gears are meshing correctly on the bus. ⚙️ 🔴 Coverage Summary
📊 Per-Skill Breakdown
🔍 Detailed Message Type Breakdown
|
| Python | Build | Install | Tests | pytest |
|---|---|---|---|---|
| 3.10 | ✅ | ✅ | ✅ | 715 passed, 1 warning, 46 subtests passed in 31.44s |
| 3.11 | ✅ | ✅ | ✅ | 715 passed, 1 warning, 46 subtests passed in 33.93s |
| 3.12 | ✅ | ✅ | ✅ | 715 passed, 1 warning, 46 subtests passed in 37.07s |
| 3.13 | ✅ | ✅ | ✅ | 715 passed, 30 warnings, 46 subtests passed in 31.03s |
| 3.14 | ✅ | ✅ | ✅ | 715 passed, 30 warnings, 46 subtests passed in 30.24s |
May your merges be conflict-free! 🕊️
This PR removes the
<3.0.0ceiling onovos-plugin-managerand keeps the floor pin.With the ceiling in place, an install of this package cannot get OPM 3. OPM 3 carries
TextEmbedder.get_embeddings_batch(ovos-plugin-manager#472) and the OVOS-TOOLS-1 call topic (ovos-plugin-manager#470). The 3.0 major bump comes from the MediaBackend v2 change (ovos-plugin-manager#442). This package imports nothing from the media, audio or agent_tools templates.What the reviewer needs to decide: merge it, so that a release of this package resolves to OPM 3.
Verified by the model, by running the commands above in fresh uv venvs (Python 3.11). The end2end tests in test/end2end did not run. No human ran these checks.
🤖 Generated with Claude Code