Skip to content

docs(ocp): the seek message carries seekValue or seconds - #43

Draft
openvoiceos-bot wants to merge 1 commit into
devfrom
docs/ocp-seek-wire-shape
Draft

openvoiceos-bot wants to merge 1 commit into
devfrom
docs/ocp-seek-wire-shape

Conversation

@openvoiceos-bot

Copy link
Copy Markdown

🤖 Auto-generated by Claude Opus 5 (claude-opus-5) via Claude Code — NOT human-reviewed. Verify before acting.

What changes

One row of the message table in docs/ocp.md. ovos.common_play.seek was documented as carrying position: int (ms). #42 replaces that field with seekValue (absolute, milliseconds) and seconds (signed relative offset), so the row named a field the model no longer has.

Stacked on #42

Based on fb52032, the head of fix/ocp-seek-wire-shape, and targeted at that branch rather than dev. The new shape does not exist until #42 merges, so this cannot land ahead of it. Retarget to dev once #42 is in, or merge it into #42 and let the pair land together — whichever the gate prefers.

Why the old row was wrong before #42 as well

ovos-bus-client's OCPInterface.seek_forward and seek_backward already emit {"seconds": N}, which the position-only model rejected. So the documented field did not match the wire before this change either; #42 is what makes the documentation correctable rather than what breaks it.

Not changed

length and position on the playback-time and track-state rows are a different model and keep their meaning. The only stale row was the seek one.

Evidence for the wire shape: knowledge/wiki/audits/gate-ledger/live-ovos-pydantic-models-42.md.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Claude <noreply@anthropic.com>
@openvoiceos-bot
openvoiceos-bot changed the base branch from fix/ocp-seek-wire-shape to dev September 26, 2026 00:50
@JarbasAl
JarbasAl force-pushed the docs/ocp-seek-wire-shape branch from 67e185d to 6719234 Compare September 26, 2026 00:50
@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Your PR status report is ready for viewing. 📜

I've aggregated the results of the automated checks for this PR below.

🏷️ Release Preview

I've checked the 'Known Issues' list for honesty. 😇

Current: 0.3.2a1 → Next: 0.3.2a2

Signal Value
Label (none)
PR title docs(ocp): the seek message carries seekValue or seconds
Bump alpha

⚠️ No conventional commit prefix — alpha-only bump.
Suggested: fix: update the thing or feat: update the thing


🚀 Release Channel Compatibility

Predicted next version: 0.3.2a2

Channel Status Note Current Constraint
Stable ⚪ Not in channel -
Testing ⚪ Not in channel -
Alpha ⚪ Not in channel -

📋 Repo Health

Is the codebase feeling fit today? Let's check. 🏃‍♂️

✅ All required files present.

Latest Version: 0.3.2a1

✅ ovos_pydantic_models/version.py — Version file
✅ README.md — README
✅ LICENSE — License file
✅ pyproject.toml — pyproject.toml
⚠️ setup.py — setup.py
✅ CHANGELOG.md — Changelog
✅ ovos_pydantic_models/version.py has valid version block markers

⚖️ License Check

Checking the terms and conditions of your code. 📝

✅ No license violations found.

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

🔨 Build Tests

Measuring the stability of the build output. 📏

✅ All versions pass

Python Build Install Tests pytest
3.10 ✅ ✅ ✅ 206 passed in 2.21s
3.11 ✅ ✅ ✅ 206 passed, 2 warnings in 1.99s
3.12 ✅ ✅ ✅ 206 passed, 2 warnings in 2.54s

Beep boop, I'm just a script 🤖

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants