Repository navigation
docs(ocp): the seek message carries seekValue or seconds - #43
openvoiceos-bot wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude <noreply@anthropic.com>
67e185d to
6719234
Compare
Your PR status report is ready for viewing. 📜I've aggregated the results of the automated checks for this PR below. 🏷️ Release PreviewI've checked the 'Known Issues' list for honesty. 😇 Current:
🚀 Release Channel Compatibility Predicted next version:
📋 Repo HealthIs the codebase feeling fit today? Let's check. 🏃♂️ ✅ All required files present. Latest Version: ✅ ⚖️ License CheckChecking the terms and conditions of your code. 📝 ✅ No license violations found. Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 🔨 Build TestsMeasuring the stability of the build output. 📏 ✅ All versions pass
Beep boop, I'm just a script 🤖 |
What changes
One row of the message table in
docs/ocp.md.ovos.common_play.seekwas documented as carryingposition: int(ms). #42 replaces that field withseekValue(absolute, milliseconds) andseconds(signed relative offset), so the row named a field the model no longer has.Stacked on #42
Based on
fb52032, the head offix/ocp-seek-wire-shape, and targeted at that branch rather thandev. The new shape does not exist until #42 merges, so this cannot land ahead of it. Retarget todevonce #42 is in, or merge it into #42 and let the pair land together — whichever the gate prefers.Why the old row was wrong before #42 as well
ovos-bus-client'sOCPInterface.seek_forwardandseek_backwardalready emit{"seconds": N}, which theposition-only model rejected. So the documented field did not match the wire before this change either; #42 is what makes the documentation correctable rather than what breaks it.Not changed
lengthandpositionon the playback-time and track-state rows are a different model and keep their meaning. The only stale row was the seek one.Evidence for the wire shape:
knowledge/wiki/audits/gate-ledger/live-ovos-pydantic-models-42.md.