Repository navigation
Conversation
…instruction recovery
0xNeshi
changed the title
…d pin the frozen unlock refusal
0xNeshi
changed the title
0xNeshi
commented
Oct 8, 2026
| -> AllocationV2.SettlementFactory_SettleBatch | ||
| -> Update AllocationV2.SettlementFactory_SettleBatchResult | ||
| settleBatchImpl pin admin self arg = do | ||
| checkActors arg.actors [arg.settlement.executors] |
Collaborator
Author
There was a problem hiding this comment.
This check is already performed in settlementFactoryV2_settleBatchDefaultImpl a couple of lines later in this function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #45
examples/toscripts/check-coverage.sh, so the coverage job now checks the custom-token example. The job failed because the example's tests never exercised 8 production choices inMyApp.Token.tokenCIP112-v1README. The README now says when a transfer completes in one step and when the receiver has to accept a pending instruction.