Skip to content

move library upgrades to their own endpoints - #4

Merged
SpaceWalkerRS merged 3 commits into
mainfrom
libraries-endpoint
Sep 8, 2025
Merged

SpaceWalkerRS merged 3 commits into
mainfrom
libraries-endpoint

Conversation

@SpaceWalkerRS

Copy link
Copy Markdown
Member

the new endpoints are libraries/:game_version/ and :generation/libraries/:game_version - this allows us to lock the upgrades for gen1 in place if we wish to do so

@SpaceWalkerRS

Copy link
Copy Markdown
Member Author

This PR does break the current installers so they will need to be updated.

@Copetan

Copetan commented Sep 3, 2025

Copy link
Copy Markdown
Member

Is the intent for the library upgrades to be optional on installation?

@SpaceWalkerRS

Copy link
Copy Markdown
Member Author

I didn't think of that. I reckon they should always be applied though, both in prod and dev. Otherwise you'll have strange crashes when mods depend on them but they're missing.

@SpaceWalkerRS

Copy link
Copy Markdown
Member Author

I wonder if the library upgrades should be specified in a local file so updating them doesn't require updating the meta itself.

@Copetan

Copetan commented Sep 3, 2025

Copy link
Copy Markdown
Member

I was wondering because the library upgrades were previously automatically applied to the profile json/zip endpoint, but now it seems that the library upgrades endpoint has to be called for the upgraded libraries to be applied upon installation

@SpaceWalkerRS

Copy link
Copy Markdown
Member Author

I see what you mean. I did that to make it more explicit that the profile json is just that what is necessary for Loader.

MMC/Prism instances keep the Loader dependencies and MC dependencies separate, so the installer has to do some jank to parse just the library upgrades from the profile JSON.

@SpaceWalkerRS

Copy link
Copy Markdown
Member Author

TODO: rebase onto new logging system once that is merged

@SpaceWalkerRS

Copy link
Copy Markdown
Member Author

tested locally that it gives the correct results

@SpaceWalkerRS
SpaceWalkerRS merged commit 71c6bc3 into main Sep 8, 2025
8 checks passed
@SpaceWalkerRS
SpaceWalkerRS deleted the libraries-endpoint branch September 8, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants