Fix union types for @param-closure-this tags - #444
Open
ace-of-aces wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
The code in this PR was written and reviewed by AI (GPT-6 Astra). I am not really proficient in Rust, but I tested the outcome and read through the code and tests.
Fixes union types in
@param-closure-this: an annotation such asFirstContext|SecondContextpreviously failed to resolve the closure's$thisbinding. This fixes the same issue that existed in Intelephense #3512.Closure bindings now resolve through the shared type engine and retain all class alternatives. The forward walker installs the binding before applying type guards, preserving narrowing in nested callbacks while allowing explicit rebinding. Call resolution also carries the alternatives through
$this,self::, andstatic::chains, with hover and navigation reflecting the union.Adds regression tests for resolution, narrowing, diagnostics, hover, and navigation, plus a working demo with runtime assertions.
Screenshot of a working example
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,examples/)config-schema.json)how it works, how it's organized), including any code drafted by an LLM.
an eye towards deleting anything that is irrelevant, clarifying anything
that is confusing, and adding details that are relevant. This includes,
for example, commit descriptions, PR descriptions, and code comments.