Repository navigation
Merge the invariant's two halted cases into one - #27
Merged
Merged
Conversation
The halted cases for ebreak and ecall differed only in which halt state they expect. One case now checks, through haltMatches, that the halt matches the instruction at the ISA's pc. The invariant is logically unchanged: (A && rest) || (B && rest) is (A || B) && rest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kristinas
marked this pull request as ready for review
November 6, 2026 19:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functional invariant's halted cases for
ebreakandecalldiffered only in which halt state they expect. They are now one case:haltMatcheschecks that the halt matches the instruction at the ISA's pc.Proof.Core.Functional.Invariant: onehaltedCaseAt(and onehaltedCasein the list form);HaltKindis gone.Obligation.hsandtest/ProofSpec.hsnow say "the halted case".The invariant is logically unchanged, but its solver queries change shape. Opened as a draft so CI runs the solver build: a local run ran out of memory.
🤖 Generated with Claude Code