Repository navigation
feat(plot): read GNSS data from vehicle_gnss - #347
Merged
Merged
Conversation
PX4 renamed vehicle_gps_position to vehicle_gnss, nested the receiver sample under 'receiver.' and dropped the units from its field names (PX4/PX4-Autopilot#24399). Logs from PX4 main no longer had a map, GPS plots, 3D view or UTC start time. Both names are read so older logs keep working.
bkueng
reviewed
Oct 16, 2026
bkueng
left a comment
bkueng
left a comment
Member
There was a problem hiding this comment.
Is this still draft? Did you test it?
pyulog also makes use of the topic: https://github.com/search?q=repo%3APX4%2Fpyulog+vehicle_gps_position&type=code.
vehicle_gps_position is only there for older logs, so it should be the fallback rather than the topic checked first.
dakejahl
marked this pull request as ready for review
October 16, 2026 16:34
Contributor
Author
|
@bkueng tested and updated. pyulog PR is here PX4/pyulog#129. And I found a small edge case during testing #351 Also opened a QGC PR here mavlink/qgroundcontrol#15317 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reads GNSS data from
vehicle_gnss, which PX4 main logs instead ofvehicle_gps_position, while still readingvehicle_gps_positionfrom older logs.Problem
PX4/PX4-Autopilot#24399 (RFC, PX4 GNSS board) renamed
vehicle_gps_positiontovehicle_gnss. The new message nests the receiver sample underreceiver.and drops the units from its field names (latitude_deg→receiver.latitude,s_variance_m_s→receiver.speed_accuracy,noise_per_ms→receiver.noise,vel_m_s→receiver.ground_speed). Flight Review didn't load the new topic, so logs from PX4 main have no map, GPS plots, 3D view, overview image or UTC start time.Solution
GnssTopicreadsvehicle_gnss, falling back tovehicle_gps_positionin older logs, and mapsvehicle_gnssreceiver field names to theirvehicle_gps_positionnames. Every consumer reads through it, andvehicle_gnssis added to the loaded topics. The rest of the rename (PX4/PX4-Autopilot#28957) doesn't change the log format. The selection fields added by the same work (usable,failed_checks,selection_count,sensors_status_gnss) aren't plotted yet.