Repository navigation
Fix/close database connections - #13
Merged
Merged
Conversation
…e daemon loop - `with open_database() as connection` commits but never closes a sqlite3 connection, so 8 call sites (main.py, cli_commands.py, queue_reports.py) left it to the garbage collector; Python 3.13+ reports that as a ResourceWarning, and an open handle can block deleting state.db on Windows - they now use `with closing(open_database()) as connection, connection:` (commit or roll back, then close), the pattern the other 34 call sites already use - the test fakes of `open_database` return a mock connection instead of a bare context manager; two unclosed files in tests are closed too Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.