Pin ruff at 0.16.4 to match what the VS Code extension bundles - #83
Merged
Merged
Conversation
Ruff 0.16 lints pyproject.toml itself, and the VS Code extension syncs config files to the language server. A pre-0.16 binary parses those TOML documents as Python source and paints phantom invalid-syntax diagnostics on lines like requires-python, so the editor disagreed with the CLI. Moving the pin from 0.14.13 to an exact 0.16.4 closes that gap. The exact pin, rather than a floor, is what keeps the two from drifting apart again. The upgrade produced no new lint findings and no reformatting; agent-check and agent-test both pass. Also drops the ruff.configuration entry from .vscode/settings.json. That setting takes a path to a config file, not a CLI flag, so the value "--config=pyproject.toml" never resolved and only worked by falling back to Ruff's normal filesystem discovery. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Confidence Score: 5/5The PR appears safe to merge with no actionable changed-code defects identified. The Ruff pin and lockfile remain consistent, the removed editor setting was ineffective, and no runtime dependency or shipped behavior changes. Reviews (1): Last reviewed commit: "Pin ruff at 0.16.4 to match what the VS ..." | Re-trigger Greptile |
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the workspace-wide ruff 0.16.4 rollout (
wip/updates/ruff-0.16.4-workspace-rollout-20260814.md). This is repo 1 of the scoped batch of seven;pipelex,conformance,pipelex-sdk-pythonandmthds-pythonlanded earlier.Why
Ruff 0.16 lints
pyproject.tomlitself, and the Ruff VS Code extension syncs config files to the language server. A pre-0.16 binary parses those TOML documents as Python source and paints phantomRuff(invalid-syntax)diagnostics on lines likerequires-python—requires-python = ...gets read asrequires - python, an invalid assignment target. The extension runs whatever binary it finds, repo venv first, so the venv pin is what has to move.The installed extension (
charliermarsh.ruff-2026.74.0) bundles ruff 0.16.4, which is why the pin lands there rather than on 0.16.2. Keeping it exact rather than a floor is what stops the editor and the CLI from drifting apart again.What changed
pyproject.toml:ruff==0.14.13→ruff==0.16.4, plus the matchinguv.lockupdate. This was the repo's only ruff pin site..vscode/settings.json: dropped"ruff.configuration": "--config=pyproject.toml". That setting takes a path to a config file, not a CLI flag, so the value never resolved — it only ever worked by falling back to Ruff's normal filesystem discovery, which finds the samepyproject.tomlanyway.Fallout: none
Nothing shipped changes — this is a dev dependency. The upgrade produced no new lint findings and no reformatting, which is what the rollout plan predicted for this repo: the ruff config here uses a narrow
selectlist withoutpreview, so none of the new preview rules or thenoqa→ruff: ignore[...]migration that dominated thepipelexsweep applies.Verification
make agent-check(fix-unused-imports, ruff format, ruff check, pyright, mypy) andmake agent-testboth pass.🤖 Generated with Claude Code
Summary by cubic
Pins
ruffto 0.16.4 to align the CLI with the VS Code extension and stop phantom invalid-syntax diagnostics onpyproject.toml. Previously pinned to 0.14.13 (pre-0.16), which parsed TOML as Python; now both editor and CLI use 0.16.4, which lints TOML correctly.Review notes
pyproject.toml:ruff==0.14.13→ruff==0.16.4; updateduv.lockandCHANGELOG.md..vscode/settings.json: removedruff.configuration(it incorrectly used a CLI flag); rely on normal config discovery.make agent-checkandmake agent-testpass.uv syncor recreate your venv to pick upruff==0.16.4.Written for commit c4537b3. Summary will update on new commits.