Bump the publish workflow's Sigstore action past the TUF root rotation - #84
Merged
Merged
Conversation
The publish workflow pinned sigstore/gh-action-sigstore-python@v3.0.0,
whose bundled sigstore-python predates the Sigstore TUF trust-root
rotation. The "Sign the dists with Sigstore" step now fails
deterministically with
tuf.api.exceptions.UnsignedMetadataError: root was signed by 0/3 keys
That step lives in the GitHub-release job, and PyPI publication is a
separate job, so the failure mode is a version published to PyPI with no
matching GitHub release or tag. That is exactly what happened to
mthds-python v0.9.0 on the same pin.
The pin now moves to v3.5.0, written as the SHA
790bc6befb9d733738f18d8f895854b453640ec9 to match how pipelex and
mthds-python already carry it. The SHA matters beyond the usual
supply-chain hygiene: the Actions allowlist is managed at the enterprise
level and already permits this exact SHA, so any other version would
need an admin to allowlist it first.
Closes L-260826-abe686
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MLDh2h2fJhY9E3YFHQ1Ana
Confidence Score: 5/5The PR appears safe to merge with no actionable regressions identified. The updated action remains compatible with the workflow’s permissions, distribution globs, generated bundle naming, and downstream release upload. Reviews (1): Last reviewed commit: "Bump the publish workflow's Sigstore act..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
.github/workflows/publish-pypi.ymlpinnedsigstore/gh-action-sigstore-python@v3.0.0, whose bundled sigstore-python predates the Sigstore TUF trust-root rotation. The Sign the dists with Sigstore step now fails deterministically with:That step sits in the GitHub-release job, and PyPI publication is a separate job, so the failure mode is a version published to PyPI with no matching GitHub release or tag — exactly what happened to
mthds-pythonv0.9.0 on the same pin.The fix
One-line pin bump to v3.5.0, written as the SHA
790bc6befb9d733738f18d8f895854b453640ec9to match howpipelexandmthds-pythonalready carry it.The SHA is not just supply-chain hygiene here: the GitHub Actions allowlist is managed at the enterprise level (above both the Pipelex and mthds-ai orgs) and already permits this exact SHA, added when
pipelexwas fixed. Any other version would first need an enterprise admin to allowlist its SHA.Evidence
mthds-python: run 33020408976, job Create GitHub Release with Changelog, step Sign the dists with Sigstore. Identical on re-run (attempt 2), so deterministic rather than transient.pipelex/.github/workflows/publish-pypi.yml:219, andmthds-pythonPR Release/v0.2.1 #46.The downstream
gh release upload "v$VERSION" dist/**step is unaffected — it globs whatever the signing step emits, and v3.x has produced.sigstore.jsonbundles throughout.Closes L-260826-abe686
🤖 Generated with Claude Code
https://claude.ai/code/session_01MLDh2h2fJhY9E3YFHQ1Ana
Summary by cubic
Bumps the publish workflow's Sigstore action from
v3.0.0to the SHA-pinnedv3.5.0so artifact signing no longer fails after the Sigstore TUF trust-root rotation. The old pin caused the "Sign the dists with Sigstore" step to fail deterministically, which published to PyPI without a matching GitHub release or tag.790bc6befb9d733738f18d8f895854b453640ec9because the enterprise Actions allowlist already permits that exact version.Written for commit 6f58678. Summary will update on new commits.