cylindrical coordinates - #2253
Draft
ddudt wants to merge 16 commits into
Draft
Conversation
Collaborator
|
More to-dos:
|
maya-avida
reviewed
Jul 23, 2026
| Options for x2 coordinate: | ||
| - z = Z | ||
| """ | ||
| coordinates = self.__dict__.setdefault("_coordinates", "rpz") |
Collaborator
There was a problem hiding this comment.
Should this be RpZ or rpz?
Collaborator
Author
There was a problem hiding this comment.
Good catch, we probably want "RpZ" to distinguish from rho and zeta
Collaborator
|
@maya-avida, if you run the following, the formatting checks/fixes will happen automatically every time you commit something. These and some other useful instructions can be found on the Contributing Guide. |
…; necessary for transform checks (can't use an R,phi,Z basis with a rho, theta, zeta grid)
…ids, but works for any tensor product grids/bases)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New grid and basis classes for working in cylindrical coordinates$(R,\phi,Z)$ . This is required for the
PlasmaFieldclass introduced in #996. This PR isolates those changes from that original PR to aid review.The order of these related PRs are:
dd/gridsdd/cylindricaldd/B_plasmama/bmw_formatTo-Do:
CylindricalGridclass, and update to new API