Remove static_attrs variables from constants dicts in _omnigenity objectives - #2297
Open
dpanici wants to merge 8 commits into
Open
Remove static_attrs variables from constants dicts in _omnigenity objectives#2297dpanici wants to merge 8 commits into
dpanici wants to merge 8 commits into
Conversation
Contributor
Memory benchmark result| Test Name | %Δ | Master (MB) | PR (MB) | Δ (MB) | Time PR (s) | Time Master (s) |
| -------------------------------------- | ------------ | ------------------ | ------------------ | ------------ | ------------------ | ------------------ |
test_objective_jac_w7x | 0.10 % | 4.247e+03 | 4.251e+03 | 4.45 | 32.04 | 28.79 |
test_proximal_jac_w7x_with_eq_update | -0.79 % | 6.873e+03 | 6.819e+03 | -54.20 | 154.35 | 153.62 |
test_proximal_freeb_jac | 0.06 % | 1.353e+04 | 1.353e+04 | 8.50 | 80.22 | 81.37 |
test_proximal_freeb_jac_blocked | 0.30 % | 7.858e+03 | 7.881e+03 | 23.28 | 68.92 | 69.44 |
test_proximal_freeb_jac_batched | -0.03 % | 7.881e+03 | 7.879e+03 | -2.35 | 68.64 | 69.57 |
test_proximal_jac_ripple | -0.52 % | 3.792e+03 | 3.772e+03 | -19.75 | 53.46 | 52.88 |
test_proximal_jac_ripple_bounce1d | -1.05 % | 4.022e+03 | 3.980e+03 | -42.40 | 69.23 | 66.65 |
test_eq_solve | -0.58 % | 1.823e+03 | 1.812e+03 | -10.55 | 53.85 | 52.62 |
test_objective_quadratic_flux_jac | 0.35 % | 1.885e+03 | 1.892e+03 | 6.67 | 36.42 | 34.89 |For the memory plots, go to the summary of |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2297 +/- ##
==========================================
- Coverage 94.35% 94.35% -0.01%
==========================================
Files 101 101
Lines 29053 29053
==========================================
- Hits 27414 27413 -1
- Misses 1639 1640 +1
🚀 New features to boost your workflow:
|
YigitElma
reviewed
Aug 21, 2026
| obj = QuasisymmetryBoozer(helicity=(1, eq1.NFP), eq=eq1) | ||
| obj = QuasisymmetryBoozer(helicity=(1, eq1.NFP), eq=eq1, surf_batch_size=1) | ||
| obj.build() | ||
| B_asym = obj.compute(*obj.xs(eq1)) |
Collaborator
There was a problem hiding this comment.
If the intent is to test if the static attribute error is fixed here, then I would suggest calling obj.compute_unscaled since plain compute is not jitted and wouldn't recreate the issue.
YigitElma
approved these changes
Aug 28, 2026
YigitElma
requested review from
a team,
IssraAli,
ddudt,
f0uriest,
lkadz,
rahulgaur104,
singh-jaydeep and
unalmis
and removed request for
a team
August 28, 2026 15:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2295