Skip to content

Ensure CoilCurvature and CoilTorsion are resolution independent - #2302

Open
singh-jaydeep wants to merge 5 commits into
masterfrom
js/resolution-coilobjective
Open

Ensure CoilCurvature and CoilTorsion are resolution independent#2302
singh-jaydeep wants to merge 5 commits into
masterfrom
js/resolution-coilobjective

Conversation

@singh-jaydeep

Copy link
Copy Markdown
Collaborator

Resolves #2301 by replacing quad_weights with their square roots for these objectives. Also strengthens the resolution independence test for coil objectives.

@singh-jaydeep
singh-jaydeep marked this pull request as ready for review August 25, 2026 15:08
@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Memory benchmark result

|               Test Name                |      %Δ      |    Master (MB)     |      PR (MB)       |    Δ (MB)    |    Time PR (s)     |  Time Master (s)   |
| -------------------------------------- | ------------ | ------------------ | ------------------ | ------------ | ------------------ | ------------------ |
  test_objective_jac_w7x                 |   -0.15 %    |     4.235e+03      |     4.228e+03      |    -6.44     |       24.32        |       23.56        |
  test_proximal_jac_w7x_with_eq_update   |   -0.13 %    |     6.863e+03      |     6.854e+03      |    -8.76     |       120.24       |       120.21       |
  test_proximal_freeb_jac                |    0.04 %    |     1.354e+04      |     1.354e+04      |     5.11     |       66.33        |       65.14        |
  test_proximal_freeb_jac_blocked        |    0.05 %    |     7.898e+03      |     7.902e+03      |     3.69     |       56.36        |       56.35        |
  test_proximal_freeb_jac_batched        |   -0.14 %    |     7.880e+03      |     7.869e+03      |    -10.72    |       55.18        |       58.05        |
  test_proximal_jac_ripple               |    0.38 %    |     3.759e+03      |     3.773e+03      |    14.38     |       41.02        |       43.17        |
  test_proximal_jac_ripple_bounce1d      |    0.08 %    |     3.978e+03      |     3.982e+03      |     3.25     |       52.97        |       54.98        |
  test_eq_solve                          |   -0.65 %    |     1.839e+03      |     1.827e+03      |    -11.97    |       41.07        |       42.55        |
  test_objective_quadratic_flux_jac      |    0.07 %    |     1.891e+03      |     1.892e+03      |     1.39     |       28.32        |       29.98        |

For the memory plots, go to the summary of Memory Benchmarks workflow and download the artifact.

@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.35%. Comparing base (187e98e) to head (94304f7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2302      +/-   ##
==========================================
+ Coverage   94.34%   94.35%   +0.01%     
==========================================
  Files         101      101              
  Lines       29042    29042              
==========================================
+ Hits        27400    27403       +3     
+ Misses       1642     1639       -3     
Files with missing lines Coverage Δ
desc/objectives/_coils.py 99.34% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dpanici

dpanici commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Can you also rerun the coil optimization notebook? Just so that they are up to date with master in case any minor changes have occurred

Comment thread CHANGELOG.md Outdated
Comment thread tests/test_objective_funs.py
singh-jaydeep and others added 3 commits August 25, 2026 20:13
Co-authored-by: Yigit Gunsur Elmacioglu <102380275+YigitElma@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Certain coil objectives depend on resolution

3 participants