Ensure CoilCurvature and CoilTorsion are resolution independent - #2302
Open
singh-jaydeep wants to merge 5 commits into
Open
Ensure CoilCurvature and CoilTorsion are resolution independent#2302singh-jaydeep wants to merge 5 commits into
singh-jaydeep wants to merge 5 commits into
Conversation
singh-jaydeep
marked this pull request as ready for review
August 25, 2026 15:08
Contributor
Memory benchmark result| Test Name | %Δ | Master (MB) | PR (MB) | Δ (MB) | Time PR (s) | Time Master (s) |
| -------------------------------------- | ------------ | ------------------ | ------------------ | ------------ | ------------------ | ------------------ |
test_objective_jac_w7x | -0.15 % | 4.235e+03 | 4.228e+03 | -6.44 | 24.32 | 23.56 |
test_proximal_jac_w7x_with_eq_update | -0.13 % | 6.863e+03 | 6.854e+03 | -8.76 | 120.24 | 120.21 |
test_proximal_freeb_jac | 0.04 % | 1.354e+04 | 1.354e+04 | 5.11 | 66.33 | 65.14 |
test_proximal_freeb_jac_blocked | 0.05 % | 7.898e+03 | 7.902e+03 | 3.69 | 56.36 | 56.35 |
test_proximal_freeb_jac_batched | -0.14 % | 7.880e+03 | 7.869e+03 | -10.72 | 55.18 | 58.05 |
test_proximal_jac_ripple | 0.38 % | 3.759e+03 | 3.773e+03 | 14.38 | 41.02 | 43.17 |
test_proximal_jac_ripple_bounce1d | 0.08 % | 3.978e+03 | 3.982e+03 | 3.25 | 52.97 | 54.98 |
test_eq_solve | -0.65 % | 1.839e+03 | 1.827e+03 | -11.97 | 41.07 | 42.55 |
test_objective_quadratic_flux_jac | 0.07 % | 1.891e+03 | 1.892e+03 | 1.39 | 28.32 | 29.98 |For the memory plots, go to the summary of |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2302 +/- ##
==========================================
+ Coverage 94.34% 94.35% +0.01%
==========================================
Files 101 101
Lines 29042 29042
==========================================
+ Hits 27400 27403 +3
+ Misses 1642 1639 -3
🚀 New features to boost your workflow:
|
Collaborator
|
Can you also rerun the coil optimization notebook? Just so that they are up to date with master in case any minor changes have occurred |
YigitElma
reviewed
Aug 25, 2026
Co-authored-by: Yigit Gunsur Elmacioglu <102380275+YigitElma@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2301 by replacing
quad_weightswith their square roots for these objectives. Also strengthens the resolution independence test for coil objectives.