Skip to content

Fixed config_tool user config export check for active vs saved. #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamshapiro0 merged 1 commit into from
Sep 30, 2026
Merged

Fixed config_tool user config export check for active vs saved. #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion bin/config_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,7 +834,13 @@ def request_export(config_interface: DeviceInterface, args):
return None
# Check the response has the expected data type to avoid handling the periodic PlatformStorageDataMessage
# output.
if data_type == data_msg.data_type:
#
# Note that user config has two sources: active (used by the engine right now, but not saved to disk) and
# saved (would replace active after a reboot). Additionally, you may request the default values, which are
# what would be used after a configuration or factory reset. We need to make sure we're getting the one we
# asked for since the device will output active and saved periodically as part of its diagnostic output.
if (data_type == data_msg.data_type and
(data_type != DataType.USER_CONFIG or data_msg.source == export_msg.source)):
break

if data_msg.response == Response.NO_DATA_STORED:
Expand Down
Loading