Repository navigation
Fix MakeMKV detection on Windows (makemkvcon64.exe with makemkvcon.exe fallback) - #31
Open
shaunmower wants to merge 4 commits into
Open
shaunmower wants to merge 4 commits into
shaunmower wants to merge 4 commits into
Conversation
14 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MakeMKV was not detected on Windows.
AppConfig.getMakeMKVExecutable()runsmakemkvcon64.exe, butdetectMakeMKVInstallation()andvalidateMakeMKVInstallation()looked formakemkvcon.exe. Recent MakeMKV installs (v2.0.0 in my case) only includemakemkvcon64.exe, so detection failed even though MakeMKV was installed.All three now use one new helper,
FileSystemUtils.findMakeMKVExecutable(). On Windows it triesmakemkvcon64.exefirst and thenmakemkvcon.exe, so installs with only the 32-bit executable keep working. Detection, validation and the command that runs always agree on which executable to use. macOS and Linux still usemakemkvcon.Type of Change
Testing
filesystem.test.js: checks that detection and validation look formakemkvcon64.exeon Windows, and thatmakemkvcon.exeis used when the 64-bit executable is missing.config.test.js: now stubsfindMakeMKVExecutablealongside the existing detection stubs, so it doesn't depend on the real filesystem.npx vitest run: all tests pass apart fromnative-optical-drive.test.js > should validate drive letter parameter, which also fails onmasterwithout this change.General Testing
npm start)Test Configuration:
Documentation
Checklist