Skip to content

db: start transactions in one round trip - #38

Merged
Uzaaft merged 1 commit into
masterfrom
perf/transaction-start
Nov 18, 2026
Merged

Uzaaft merged 1 commit into
masterfrom
perf/transaction-start

Conversation

@Uzaaft

@Uzaaft Uzaaft commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Every transaction-start helper now sends its SET LOCAL settings and
its BEGIN as one simple-query message. Before, a write transaction
sent BEGIN and then lock_timeout as separate statements, a sweep sent
BEGIN and two settings, and a patient sweep a third. The database is
about 2 ms away per round trip, every write request opens at least one
transaction, and an upload opens dozens, so the extra trips were a
fixed cost on each of them.

The settings precede BEGIN. PostgreSQL runs a multi-statement message
in an implicit transaction block and a BEGIN inside it adopts the
statements before it, so the settings still end with the transaction.
The order matters when a setting is refused: the implicit block rolls
back and the connection is idle. With BEGIN first the transaction is
left aborted, SQLx 0.9 has not counted it yet and so never rolls it
back, and the pool hands the connection to the next caller.

The two SET LOCAL query macros in maintenance are gone, and their
offline metadata with them.
@Uzaaft
Uzaaft merged commit 63f9516 into master Nov 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant