Repository navigation
db: start transactions in one round trip - #38
Merged
Merged
Conversation
Every transaction-start helper now sends its SET LOCAL settings and its BEGIN as one simple-query message. Before, a write transaction sent BEGIN and then lock_timeout as separate statements, a sweep sent BEGIN and two settings, and a patient sweep a third. The database is about 2 ms away per round trip, every write request opens at least one transaction, and an upload opens dozens, so the extra trips were a fixed cost on each of them. The settings precede BEGIN. PostgreSQL runs a multi-statement message in an implicit transaction block and a BEGIN inside it adopts the statements before it, so the settings still end with the transaction. The order matters when a setting is refused: the implicit block rolls back and the connection is idle. With BEGIN first the transaction is left aborted, SQLx 0.9 has not counted it yet and so never rolls it back, and the pool hands the connection to the next caller. The two SET LOCAL query macros in maintenance are gone, and their offline metadata with them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.