Repository navigation
server: serve Bazel over gRPC on organization hosts - #45
Merged
Merged
Conversation
An organization host answered every request as a Nix read, so the Go
and sccache caches were reachable only under /_api/v1/<product>/<org>/
<cache> on the shared host. Customers should configure one address
shape, <org>.<suffix>/<cache>/<product>.
The cache router now registers /{cache}/go and /{cache}/sccache with
their trailing forms. On an organization host their handler rewrites
the path to the canonical protocol route and dispatches it into a
router holding only the Go and sccache routes, so authorization, limits,
and storage are the existing handlers' and management or upload routes
stay unreachable from an organization host. On any other host the same
shape remains a path-based Nix read, which keeps caches named go or
sccache working. PROPFIND answers with the path the client used.
Two things change shape. On an organization host, a product path with a
method the protocol rejects now gets the protocol's JSON 404 or 405
instead of the Nix read's 405. Requests matching the new routes are
labelled with them in metrics rather than as cache reads.
Organization hosts served Go and sccache at /<cache>/<product>, but Bazel's HTTP cache was still reachable only under /_api/v1/bazel/<org>/ <cache> on the shared host. Bazel joins the product list. Its router is split so the HTTP route can be dispatched from an organization host on its own: the gRPC services stay out of the organization-host router and remain unreachable there. The handler, limits, and store are unchanged, and both addresses read the same entries. Responses on an organization host keep their own Cache-Control but are marked no-store for the CDN, like every other response there, so only anonymous reads of public caches on the shared host are edge-cached.
Bazel's gRPC services answered only on the shared host, with the organization and cache packed into the instance name as <org>/<cache>. On an organization host every gRPC call was treated as a Nix read. An organization host now runs the gRPC routes, and there the host names the organization while the instance names only the cache. ByteStream resource names follow the same rule. The shared host keeps <org>/<cache> unchanged, and each host accepts only its own shape, so a name can never resolve in two organizations. HTTP/2 clients that connect directly send the host as :authority with no Host header. Ingress reads the request URI's authority in that case, and only then: a Host header always wins, and a malformed authority is rejected like a malformed Host. Behind nginx nothing changes, since it forwards a Host header. A gRPC client that reaches a refused host, such as the apex or a reserved name, still gets a plain 404 rather than a gRPC status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third of three stacked PRs for Polymath-AS/snowstead-service#20. Stacked on #44.
Serves Bazel's gRPC cache on organization hosts as
grpcs://<org>.<suffix>with--remote_instance_name=<cache>. The shared host keeps<org>/<cache>; each host accepts only its own shape.openand ByteStream resource parsing take the organization from the host when there is one. Every gRPC method passes it.Hostheader is sent (direct HTTP/2 clients).Hostalways wins; nginx forwardsHost, so the production path is unchanged.Known and not addressed here: a gRPC client on a refused host (apex, reserved names) gets a plain-text 404, which Bazel reports as a protocol error.
Not verifiable locally: gRPC on organization hosts through Cloudflare. The service repo's runbook requires that check on staging before the address is announced.
pnpm checkpasses.