fix: harden Trino registry-only routes and fixture readiness - #1173
Draft
benben wants to merge 5 commits into
Draft
fix: harden Trino registry-only routes and fixture readiness#1173benben wants to merge 5 commits into
benben wants to merge 5 commits into
Conversation
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: neutral or increased No coverage-reduction warnings detected. |
bill-ph
approved these changes
Sep 11, 2026
bill-ph
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the bounded registry-convergence helper and its behavioral coverage. It retries transient API/refused/stale responses with a finite timeout, validates the exact expected cell set, and fails with an actionable message rather than proceeding on stale configuration. No runtime or deployment configuration changes are introduced, and I found no P0 blocker requiring a code change. The PR remains draft pending the live registry-only validation.\n\n— Robo Bill
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/bundlesand/bundles/API paths instead of serving the admin SPA. Registered bundle authentication and ordinary UI routes are unchanged.test -ron every ready legacy or registered worker before initial writes. Scope permissions to the existing isolated fixture namespaces.Validation
just test-mw-fixturesandjust lintpass. Independent adversarial review approved the bounded fix.