fix: retire control-plane pods before Trino rollout assertions - #1181
Open
bill-ph wants to merge 1 commit into
Open
fix: retire control-plane pods before Trino rollout assertions#1181bill-ph wants to merge 1 commit into
bill-ph wants to merge 1 commit into
Conversation
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: neutral or increased No coverage-reduction warnings detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An idle control-plane pod could exit before Service routing stopped selecting it. The first API request after a successful Deployment rollout then received a TCP reset and the Trino harness mislabeled it as an unexpected legacy cell.
Add a five-second
preStoprouting-withdrawal allowance to the isolated deployment, preserving its previous 30-second drain budget with a 35-second termination grace period. Each Trino configuration transition now captures the previous pod names and waits for those exact pods to terminate before making the unchanged one-shot assertion. Transport and content failures remain fatal and receive distinct diagnostics. The README and rollout runbook document the lifecycle and recovery procedure.This changes the isolated E2E deployment and harness; it does not change the application binary or production chart.
Validation:
just test-mw-fixturespasses.just lintpasses with CI's pinned golangci-lint 2.11.4 and Go 1.25.4.cell-test.