Repository navigation
Unify EvEMTBench MCP tools and address PowerFactory follow-ups - #122
Merged
qian-harvard merged 5 commits intoOct 22, 2026
Conversation
qian-harvard
approved these changes
Oct 22, 2026
qian-harvard
left a comment
Contributor
There was a problem hiding this comment.
Thanks, this works well. Merged on top of main:
- PowerFactory/tests: 166 passed, 85 subtests passed.
- Other CI suites: 503 passed.
- The wheel ships all six catalogs and every unified listing works.
- The server exposes only
list_evemtbench_componentsandcreate_evemtbench_componentfor EvEMTBench. - Each removed create/list tool's signature matches the unified
creation_parameters/filtersexactly, so nothing that was creatable before has become unreachable. - Both #113 follow-ups are correct: the PDF export keeps its own outcome when the restore fails, and the grid-bootstrap token is bound to the destination plan.
Small follow-ups, none blocking:
create_evemtbench_componenttakes an untypedparametersdict, and the creators readout_of_service/open_digsilentwithbool(...)(e.g.evemtbench.py:1619,1866). So"out_of_service": "false"becomesTrue. The preview token showsout_of_service=1before confirmation, which limits the damage, but anisinstance(..., bool)check like the existingseedcheck would reject it outright.references/tool_guide.md:723still says "the public MCP tool names and arguments are unchanged". That sentence came from the old README and contradicts this PR.references/tool_guide.mdisn't in the wheel's force-include list, so the README links to it don't resolve in an installed package.references/evemtbench.mdhas the same gap. The links work on GitHub.
The tool consolidation is a breaking change for MCP clients, so we'll call it out in the next release notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates the EvEMTBench MCP interface and addresses the two follow-up remarks from PR #113.
Unified equipment interface
Only two EvEMTBench tools are exposed:
list_evemtbench_components(component_type, filters)create_evemtbench_component(component_type, parameters)The listing tool supports transformers, overhead lines, underground cables, external grids, loads and synchronous machines. Responses include catalog data, mapping limitations, supported filters, and creation-parameter names, types, required flags and defaults.
Specialized implementations remain internal. Their separate MCP wrappers are removed, and documentation includes migration examples.
This intentionally changes the MCP interface. Existing specialized calls must migrate to the unified tools, and clients must refresh their tool list.
Maintainer follow-ups
Validation
git diff --checkpassed.Confirmed equipment creation was not rerun for this update. The new bootstrap-destination and PDF warning cases have automated coverage only.