Repository navigation
Harden HOPE Julia subprocess argument handling - #130
Conversation
Validate debug solver selection, pass caller-controlled values through Julia ARGS, and add regression coverage. Responsibly reported by @hexisteme.
|
@hexisteme Thank you for the proposed remediation. This PR implements both requested changes and adds argument-based separation as defense-in-depth. All local and upstream CI tests pass. Your review would be appreciated before release. |
|
Reviewed — looks good to me, thanks for the fast and thorough fix. It fully addresses the reported issue and goes further than I proposed: the I also checked LGTM to release. One request for the security side: could you publish a GitHub Security Advisory for this and request a CVE from the draft (GitHub is a CNA), crediting me (@hexisteme) as reporter? Happy to be added to the advisory draft if you enable Private Vulnerability Reporting. Thanks again! |
qian-harvard
left a comment
There was a problem hiding this comment.
Reviewed and verified locally: the HOPE suite passes, and a real Julia run confirms that values passed through ARGS (including $(run(...))) arrive as literal text. Thanks @swang22 for the fix and @hexisteme for the report and review. This ships as 0.4.1, and advisory GHSA-6mvp-cq74-hhf5 is in draft.
Patch release carrying only the HOPE Julia code-injection fix (Power-Agent#130) on top of 0.4.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary
Validation
Responsibly reported by @hexisteme. This implements both remediations proposed by the reporter, with the additional ARGS separation above. Reporter review is welcome before release.
The GitHub Security Advisory, reporter collaborator/credit, and CVE request should be coordinated separately by a PowerMCP repository maintainer.