Repository navigation
Add opt-in EvEMTBench ZIP loads and YNd11 zero-sequence mapping and address PR #122 follow-ups - #138
Merged
qian-harvard merged 5 commits intoOct 30, 2026
Conversation
qian-harvard
approved these changes
Oct 30, 2026
qian-harvard
left a comment
Contributor
There was a problem hiding this comment.
Thanks, all three #122 follow-ups are fixed, and both new modes are opt-in with the defaults unchanged. Merged onto current main:
- The full CI suite passes: 744 passed, 459 subtests passed.
out_of_serviceoropen_digsilentset to"false"or0is now rejected before connecting, for every component type.- The obsolete "unchanged" sentence is gone. The built wheel ships all three reference pages, and
evidence/stays out of the sdist. list_evemtbench_componentsadvertisesload_model,type_name,zero_sequence_model,r0_r1_ratioandx0_x1_ratiowith the right defaults.ynd11_equivalentrejects ratios that are missing, boolean, strings or outside the Table 10 three-limb intervals. It also rejects any transformer that isn't 20 MVA, 110/20 kV, 60 Hz YNd11.- ZIP sampling keeps every coefficient inside its Table 5 interval, and each set sums to 1.
I can't run PowerFactory here, so the live behaviour rests on your FT-28 to FT-32 Lab PC evidence, which is thorough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the three follow-ups from PR #122 and adds opt-in EvEMTBench ZIP loads and a restricted transformer zero-sequence equivalent.
PR #122 follow-ups
out_of_serviceandopen_digsilentinputs before connecting to PowerFactory.Opt-in ZIP loads
load_model="zip"with an explicit newtype_name.Opt-in transformer zero-sequence equivalent
zero_sequence_model="ynd11_equivalent"for 20 MVA, 110/20 kV, 60 Hz, YNd11 only.zero_sequence_model="unchanged"as the default.r0_r1_ratioandx0_x1_ratiowithin Table 10 three-limb numerical intervals.Validation
8.94e-9, against a predeclared 0.5% relative / 0.00001 kA absolute tolerance.Scope and limitations
The voltage-response and earth-fault calculations used separate diagnostic networks. No calculation was run on either integrated out-of-service component.
FT-32 establishes independent absolute-current agreement only for the restricted unloaded, lossless equivalent. It does not certify absolute currents for the original lossy transformer or the integrated transformer, and does not widen the creator's supported configurations.
Physical core/limb, zero-sequence magnetizing, internal-delta YNyn and saturation mappings remain unsupported. RMS/EMT behavior remains unvalidated.