Fix TypeError in SubjectRegistration.approxHeadCenter - #22
Open
BrennanTM wants to merge 1 commit into
Open
Conversation
Averaged the LPA/RPA Fiducial objects instead of their planned coordinates, raising TypeError whenever both fiducials were planned. Also guard the property's sole caller (SubjectRegistrationPanel camera alignment on fiducial row selection), which subtracted the property's documented None return from an ndarray whenever LPA/RPA were absent or unplanned, e.g. after planning a NAS fiducial first. The camera now falls back to just resetting on the focal point in that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke —
SubjectRegistration.approxHeadCenteraveraged the LPA/RPAFiducialobjects instead of theirplannedCoordarrays →TypeErrorwhenever both were planned.Fix — average the coordinates. Also guard the sole caller (
SubjectRegistrationPanel, camera alignment on fiducial-row selection), which subtracted the property's documentedNonereturn from an ndarray when LPA/RPA were unplanned (e.g. plan NAS first, click its row); it now just resets on the focal point.Tests —
tests/test_Model/test_subjectRegistrationCalcs.py(2).